Repository navigation
fix(dts): try the .json file itself after .d.json.ts for json imports - #1377
Merged
Merged
Conversation
ocavue
marked this pull request as ready for review
September 7, 2026 08:40
2 tasks done
Boshen
enabled auto-merge (squash)
September 23, 2026 07:18
Merging this PR will degrade performance by 6.78%
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolve_dtsonly tried.d.json.tsforimport "./data.json"and never the.jsonfile itself, so JSON imports failed under the dts resolver even though TypeScript's bundler mode resolves them (resolveJsonModuledefaults totruethere).This mirrors
tryAddingExtensionsin TypeScript (linked in the code comments): https://github.com/microsoft/TypeScript/blob/v6.0.3/src/compiler/moduleNameResolver.ts#L2155-L2158Re-implements #1052, which was merged into a stacked branch and never reached
main.