feat: correctly calculate emoji sequences width#85
Merged
Conversation
camc314
force-pushed
the
c/09-16-feat_correctly_calculate_emoji_sequences_width
branch
from
853286b to
49fdd3f
Compare
camc314
force-pushed
the
c/09-16-feat_correctly_calculate_emoji_sequences_width
branch
from
49fdd3f to
e107049
Compare
Boshen
deleted the
c/09-16-feat_correctly_calculate_emoji_sequences_width
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Improve handling of Unicode graphemes in error reporting, particularly for emoji sequences.
What changed?
unicode-segmentationcrate as a dependencyGraphicalReportHandlerto properly handle:CharWidthIteratorthat correctly calculates visual widths for both ASCII and Unicode textHow to test?
Added a new test file
test_emoji_underline.rsthat verifies proper underline rendering for:Why make this change?
Previously, the error reporting system didn't correctly handle complex Unicode graphemes, especially emoji sequences composed of multiple code points. This caused underlines in error messages to be misaligned when displaying errors in text containing emoji. The new implementation ensures that error spans and underlines are correctly aligned with the visual representation of the text, improving readability of error messages.
Ref: oxc-project/oxc#13365