Closed
Conversation
9c4d02e to
529cc5e
Compare
camc314
reviewed
Sep 15, 2025
Member
Author
|
@camc314 Yeah I had considered that at first, but didn't want to go too deep into this before getting some feedback. I can update this to use the JSON output though, I think we just need to make sure the diagnostics are sorted first and it should be okay. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Adds an extra check to ecosystem to run oxlint with/without optimizations turned on. They are turned on by default, but we want to try running with them off to ensure that the diagnostic count emitted is exactly the same.