Skip to content

feat: add optimization tests#52

Closed
camchenry wants to merge 1 commit intomainfrom
09-12-feat_add_optimization_tests
Closed

feat: add optimization tests#52
camchenry wants to merge 1 commit intomainfrom
09-12-feat_add_optimization_tests

Conversation

@camchenry
Copy link
Copy Markdown
Member

@camchenry camchenry commented Sep 13, 2025

Adds an extra check to ecosystem to run oxlint with/without optimizations turned on. They are turned on by default, but we want to try running with them off to ensure that the diagnostic count emitted is exactly the same.

Copy link
Copy Markdown
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Copy Markdown
Contributor

@camc314 camc314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it'd be better to use --format=json, parse the output and then assert that the actual diagnostics are identical rather than just relying on the count

@camchenry
Copy link
Copy Markdown
Member Author

@camc314 Yeah I had considered that at first, but didn't want to go too deep into this before getting some feedback. I can update this to use the JSON output though, I think we just need to make sure the diagnostics are sorted first and it should be okay.

@camchenry camchenry closed this Sep 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants