Skip to content

ci: use codspeed mode input #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Boshen merged 1 commit into from
Jun 26, 2026
Merged

ci: use codspeed mode input #191

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/benchmark.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,6 @@ jobs:
uses: CodSpeedHQ/action@63f3e98b61959fe67f146a3ff022e4136fe9bb9c # v4.17.6
timeout-minutes: 15
with:
simulation: true
mode: simulation

@chatgpt-codex-connector chatgpt-codex-connector Bot Jun 26, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Remove duplicate mode input that overrides simulation

When this workflow runs, the with map now contains two mode keys; common YAML parsing keeps the later value, so the pinned CodSpeed action receives mode: instrumentation instead of the new mode: simulation. That leaves this migration ineffective and keeps using the deprecated legacy name despite the commit’s intent; remove the later mode: instrumentation entry.

Useful? React with 👍 / 👎.

run: cargo codspeed run
mode: instrumentation