Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frecodecamp first problem #60

Merged
merged 5 commits into from
Oct 21, 2018
Merged

Frecodecamp first problem #60

merged 5 commits into from
Oct 21, 2018

Conversation

Avinash369
Copy link
Contributor

First Freecodecamp problem

@ows-ali
Copy link
Owner

ows-ali commented Oct 18, 2018

Add your name and info in Contributors list in README, add the url in comments or description and rename your file in this way:
https://learn.freecodecamp.org/responsive-web-design/basic-html-and-html5/uncomment-html/

becomes
responsive-web-design_basic-html-and-html5_uncomment-html.js
(means replacing slash '/' with underscore '_'

Please feel to ask if you have any queries
@Avinash369

@Avinash369
Copy link
Contributor Author

@Avinash369
Copy link
Contributor Author

I have proposed a change in Readme for contributors. Is it ok or do i have to change on my local machine and then push it to the repo

@ows-ali
Copy link
Owner

ows-ali commented Oct 19, 2018

Yes @Avinash369 use this name 'coding-interview-prep_project-euler_problem-1-multiples-of-3-and-5.json' as the name of the file.
Also, yes you need to push the updated README.md and push it to your forked repo (Avinash369:master). It will automatically come here

@Avinash369
Copy link
Contributor Author

changed the file name and also updated the README.md
check if anything else is needed

@ows-ali ows-ali merged commit 31d7859 into ows-ali:master Oct 21, 2018
@welcome
Copy link

welcome bot commented Oct 21, 2018

Congrats on merging your first pull request! Keep it up!

@ows-ali
Copy link
Owner

ows-ali commented Oct 21, 2018

Thanks @Avinash369 for choosing the theme. It looks nice and now working on https://ows-ali.github.io/Hacktoberfest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants