Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use php 8.3 #4

Merged
merged 5 commits into from
Dec 22, 2023
Merged

feat: use php 8.3 #4

merged 5 commits into from
Dec 22, 2023

Conversation

Sjoertjuh
Copy link
Contributor

No description provided.

dees040
dees040 reviewed Dec 15, 2023
View reviewed changes
Copy link
Member

@dees040 dees040 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we need to wait for Imagick/imagick#641 to be fixed?

@Sjoertjuh
Copy link
Contributor Author

There is a way to build it yourself, but I don't think that is a nice solution. So if you want to use imagick, then yes.

@Sjoertjuh Sjoertjuh requested a review from dees040 December 22, 2023 08:38
@Sjoertjuh Sjoertjuh merged commit 20206f2 into main Dec 22, 2023
1 check passed
@Sjoertjuh Sjoertjuh deleted the feature/php-8-3 branch December 22, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasowow thomasowow thomasowow approved these changes

@dees040 dees040 Awaiting requested review from dees040

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sjoertjuh @dees040 @thomasowow