Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSM Tile Scale Factor #1262

Merged
merged 2 commits into from
Aug 8, 2022
Merged

OSM Tile Scale Factor #1262

merged 2 commits into from
Aug 8, 2022

Conversation

growse
Copy link
Collaborator

@growse growse commented Aug 5, 2022

Added osmTileScaleFactor preference to allow control of how large the OSM tiles are drawn, to help with readability (#1223)

@codecov
Copy link

codecov bot commented Aug 5, 2022

Codecov Report

Merging #1262 (aeee6bc) into master (2122d1a) will decrease coverage by 0.10%.
The diff coverage is 50.00%.

@@             Coverage Diff              @@
##             master    #1262      +/-   ##
============================================
- Coverage     58.08%   57.98%   -0.11%     
- Complexity     1221     1225       +4     
============================================
  Files           171      171              
  Lines          6628     6643      +15     
  Branches        672      674       +2     
============================================
+ Hits           3850     3852       +2     
- Misses         2281     2288       +7     
- Partials        497      503       +6     
Flag Coverage Δ
uitests 52.91% <25.00%> (-0.15%) ⬇️
unittests 14.28% <37.50%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...roid/support/preferences/SharedPreferencesStore.kt 65.21% <0.00%> (-2.97%) ⬇️
.../java/org/owntracks/android/support/Preferences.kt 79.52% <58.33%> (-0.33%) ⬇️
...org/owntracks/android/ui/map/osm/OSMMapFragment.kt 81.48% <100.00%> (+0.09%) ⬆️
...rg/owntracks/android/geocoding/GeocoderLRUCache.kt 62.50% <0.00%> (-25.00%) ⬇️
.../java/org/owntracks/android/ui/map/MapViewModel.kt 66.48% <0.00%> (-1.65%) ⬇️
.../owntracks/android/services/BackgroundService.java 43.68% <0.00%> (-0.27%) ⬇️
.../owntracks/android/services/LocationProcessor.java 34.34% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

… OSM tiles are drawn, to help with readability (#1223)
@growse growse force-pushed the osm-tile-scale-factor branch from 85c1eb3 to 98732c6 Compare August 5, 2022 14:34
@growse growse merged commit d13b172 into master Aug 8, 2022
@growse growse deleted the osm-tile-scale-factor branch August 8, 2022 11:43
@growse growse restored the osm-tile-scale-factor branch August 8, 2022 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant