[docs-only] [adr] New decision was made to use kql #6611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micbar
requested review from
butonic,
dragotin,
kulmann,
felix-schwarz,
JammingBen and
michaelstingl
mmattel
reviewed
Jun 23, 2023
JammingBen
approved these changes
Jun 26, 2023
There was a problem hiding this comment.
We also agreed that we want to support :-prefixed shortcuts/macros that are internally expanded into a longer expression, like f.ex. :documents expanding into a query that matches the different document formats.
Not sure if this PR is the right place for that - or if it should be documented separately.
|
@felix-schwarz we should add that aspect here. Will do. |
Co-authored-by: Martin <[email protected]> Signed-off-by: Michael Barz <[email protected]>
|
@felix-schwarz |
felix-schwarz
approved these changes
Jun 26, 2023
ownclouders
pushed a commit
that referenced
this pull request
Jun 26, 2023
[docs-only] [adr] New decision was made to use kql
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change our query language ADR to reflect the outcome of our last discussion.
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: