-
Notifications
You must be signed in to change notification settings - Fork 221
[full-ci][OCISDEV-355] Fix delete stale nodes command #11704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e56c38d
to
11691fe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes the delete stale nodes command to properly handle node cleanup by implementing event-driven revert operations instead of direct file system deletion. The fix ensures that stale processing nodes are properly rolled back through the event system rather than being forcefully removed.
- Replaces direct file deletion with event-based revert revision mechanism
- Updates function signatures to accept an event stream parameter
- Adds resource ID extraction functionality for proper event handling
Reviewed Changes
Copilot reviewed 4 out of 19 changed files in this pull request and generated 3 comments.
File | Description |
---|---|
services/storage-users/pkg/command/uploads.go | Core fix implementing event-based node cleanup with stream handling and resource ID extraction |
go.mod | Updates NATS and Reva dependencies to support the event system changes |
changelog/unreleased/fix-stale-nodes-command.md | Documents the bugfix for the stale nodes command |
changelog/unreleased/bump-reva.md | Records the dependency update as part of this PR |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
11691fe
to
c04ecac
Compare
This is release notes (docs-main) and likely changed commands (docs-ocis) relevant. |
Signed-off-by: Julian Koberg <[email protected]>
Signed-off-by: Julian Koberg <[email protected]>
c04ecac
to
5efa32a
Compare
|
[full-ci][OCISDEV-355] Fix delete stale nodes command
Fixes the stale nodes command.
See https://kiteworks.atlassian.net/browse/OCISDEV-355