Skip to content

Conversation

kobergj
Copy link
Collaborator

@kobergj kobergj commented Oct 1, 2025

Fixes the stale nodes command.

See https://kiteworks.atlassian.net/browse/OCISDEV-355

@kobergj kobergj force-pushed the FixStaleNodesCommand branch 2 times, most recently from e56c38d to 11691fe Compare October 1, 2025 13:44
@kobergj kobergj marked this pull request as ready for review October 1, 2025 13:44
@kobergj kobergj requested a review from Copilot October 1, 2025 13:44
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the delete stale nodes command to properly handle node cleanup by implementing event-driven revert operations instead of direct file system deletion. The fix ensures that stale processing nodes are properly rolled back through the event system rather than being forcefully removed.

  • Replaces direct file deletion with event-based revert revision mechanism
  • Updates function signatures to accept an event stream parameter
  • Adds resource ID extraction functionality for proper event handling

Reviewed Changes

Copilot reviewed 4 out of 19 changed files in this pull request and generated 3 comments.

File Description
services/storage-users/pkg/command/uploads.go Core fix implementing event-based node cleanup with stream handling and resource ID extraction
go.mod Updates NATS and Reva dependencies to support the event system changes
changelog/unreleased/fix-stale-nodes-command.md Documents the bugfix for the stale nodes command
changelog/unreleased/bump-reva.md Records the dependency update as part of this PR

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@kobergj kobergj force-pushed the FixStaleNodesCommand branch from 11691fe to c04ecac Compare October 1, 2025 13:57
@mzner mzner self-requested a review October 1, 2025 13:59
@mmattel
Copy link
Contributor

mmattel commented Oct 1, 2025

This is release notes (docs-main) and likely changed commands (docs-ocis) relevant. ocis storage-users delete-stale-nodes. I'll take care...

Julian Koberg added 2 commits October 1, 2025 16:09
Signed-off-by: Julian Koberg <[email protected]>
Signed-off-by: Julian Koberg <[email protected]>
@kobergj kobergj force-pushed the FixStaleNodesCommand branch from c04ecac to 5efa32a Compare October 1, 2025 14:09
Copy link

sonarqubecloud bot commented Oct 1, 2025

@kobergj kobergj merged commit 39f20f1 into owncloud:master Oct 2, 2025
4 checks passed
@kobergj kobergj deleted the FixStaleNodesCommand branch October 2, 2025 07:15
ownclouders pushed a commit that referenced this pull request Oct 2, 2025
[full-ci][OCISDEV-355] Fix delete stale nodes command
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants