[tests-only][full-ci] added test to list shares after disabling Editor role #11057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
PrajwolAmatya
force-pushed
the
disable-role
branch
from
7ff2ffb to
80b4198
Compare
PrajwolAmatya
requested review from
anon-pradip,
ishabaral,
saw-jan,
prashant-gurung899,
Salipa-Gurung,
amrita-shrestha,
nabim777,
S-Panta and
nirajacharya2
and removed request for
anon-pradip,
ishabaral,
saw-jan,
prashant-gurung899,
Salipa-Gurung,
amrita-shrestha,
nabim777,
S-Panta and
nirajacharya2
PrajwolAmatya
requested review from
anon-pradip,
ishabaral,
saw-jan,
prashant-gurung899 and
Salipa-Gurung
PrajwolAmatya
requested review from
amrita-shrestha,
nabim777,
S-Panta and
nirajacharya2
tests/acceptance/features/apiSharingNg1/enableDisablePermissionsRole.feature
Outdated
Show resolved
Hide resolved
PrajwolAmatya
force-pushed
the
disable-role
branch
from
80b4198 to
6b94942
Compare
| @@ -715,3 +715,589 @@ Feature: enable disable permissions role | |||
| | Space Viewer | | a8d5fe5e-96e3-418d-825b-534dbdf22b99 | | |||
| | Space Editor | DNVCK | 58c63c02-1d89-4572-916a-870abc5a1b7d | | |||
| | Manager | RDNVCKZP | 312c0871-5ef7-4b3a-85b6-0e4074c64049 | | |||
|
|
|||
|
|
|||
| Scenario: users list the folder shares shared with Editor role after the role is disabled (Personal Space) | |||
There was a problem hiding this comment.
What happens when role get disabled before sharing. Can we still share resource. Did we already cover such cases
There was a problem hiding this comment.
We get the following response
{
"error": {
"code": "invalidRequest",
"innererror": {
"date": "2025-02-27T05:42:33Z",
"request-id": "<request-id>"
},
"message": "Key: 'DriveItemInvite.Roles' Error:Field validation for 'Roles' failed on the 'available_role' tag"
}
}We don't have test coverage for this case. I will add this case on a separate PR. 👍
Merged
9 tasks
tests/acceptance/features/apiSharingNg1/enableDisablePermissionsRole.feature
Outdated
Show resolved
Hide resolved
PrajwolAmatya
force-pushed
the
disable-role
branch
from
6b94942 to
fb532a8
Compare
| And the administrator has disabled the permissions role "Editor" | ||
| When user "Alice" lists the shares shared by her using the Graph API | ||
| Then the HTTP status code should be "200" | ||
| And the JSON data of the response should contain resource "folderToShare" with the following data: |
There was a problem hiding this comment.
minimize json response
PrajwolAmatya
force-pushed
the
disable-role
branch
from
fb532a8 to
1d5aaea
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the test to share resource with Editor role, disabling the Editor role and users listing the shares.
Related Issue
Types of changes
Checklist: