Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci][tests-only]Add support to update running service in ociswrapper #11003

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

amrita-shrestha
Copy link
Contributor

@amrita-shrestha amrita-shrestha commented Feb 13, 2025

Description

This PR add support to update running service with extra env.

Tests cases

  1. run oCIS and start oCIS service
  2. run oCIS and update oCIS env with PUT method
    • curl -XPUT 'http://localhost:5200/config' -d'{"OCIS_EXCLUDE_RUN_SERVICES":"storage-users"}'
  3. run multiple ocis service
    • curl -XPOST 'http://localhost:5200/services/audit' -d'{"OCIS_LOG_LEVEL":"info"}'
    • curl -XPOST 'http://localhost:5200/services/storage-users' -d'{"OCIS_LOG_LEVEL":"info"}'
  4. update running service
    • curl -XPATCH 'http://localhost:5200/services/storage-users' -d'{"OCIS_LOG_LEVEL":"warn"}'

Related Issue

Motivation and Context

How Has This Been Tested?

  • locally

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@amrita-shrestha amrita-shrestha force-pushed the add-support-to-update-restart-ocis-service branch 2 times, most recently from af49f31 to c454b95 Compare March 4, 2025 11:25
@amrita-shrestha amrita-shrestha requested a review from saw-jan March 4, 2025 11:30
@amrita-shrestha amrita-shrestha force-pushed the add-support-to-update-restart-ocis-service branch from c454b95 to 1d2dab4 Compare March 5, 2025 04:27
@amrita-shrestha amrita-shrestha force-pushed the add-support-to-update-restart-ocis-service branch from 1d2dab4 to 2b34c2f Compare March 5, 2025 06:39
@amrita-shrestha amrita-shrestha requested a review from saw-jan March 5, 2025 06:39
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@amrita-shrestha amrita-shrestha force-pushed the add-support-to-update-restart-ocis-service branch from 2b34c2f to 12875a0 Compare March 6, 2025 03:52
Copy link

sonarqubecloud bot commented Mar 6, 2025

@amrita-shrestha amrita-shrestha merged commit 184ee57 into master Mar 6, 2025
4 checks passed
@amrita-shrestha amrita-shrestha deleted the add-support-to-update-restart-ocis-service branch March 6, 2025 04:43
ownclouders pushed a commit that referenced this pull request Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants