Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci] add test to disable mail and in-app notifications when receiving a federated share #10973

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

prashant-gurung899
Copy link
Contributor

Description

This PR adds test to disable mail and in-app notification for Share Received event for OCM.

Scenario: federated user disables mail and in-app notification for "Share Received" event

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@prashant-gurung899 prashant-gurung899 force-pushed the test/disable-ocm-notifications branch from ef8f191 to 4e6b1fb Compare February 12, 2025 11:29
Copy link
Contributor

@PrajwolAmatya PrajwolAmatya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -1,4 +1,4 @@
@ocm
@ocm @notification
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the tag required? and why?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes because the email notifications from prior scenarios weren't cleaned up which made CI to fail.
The notifications were related to invitation/collaboration. See build: https://drone.owncloud.com/owncloud/ocis/43375/46/9

[0]=>
      │   object(stdClass)#4013 (9) {
      │     ["mailbox"]=>
      │     string(5) "brian"
      │     ["id"]=>
      │     string(20) "20250212T063355-0001"
      │     ["from"]=>
      │     string(47) "Alice Hansen via ownCloud <[email protected]>"
      │     ["to"]=>
      │     array(1) {
      │       [0]=>
      │       string(19) "<[email protected]>"
      │     }
      │     ["subject"]=>
      │     string(58) "ScienceMesh: {InitiatorName} wants to collaborate with you"
      │     ["date"]=>
      │     string(30) "2025-02-12T06:33:55.162188624Z"
      │     ["posix-millis"]=>
      │     int(1739342035162)
      │     ["size"]=>
      │     int(2737)
      │     ["seen"]=>
      │     bool(false)
      │   }

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then we should think of better solution again. Maybe do mailbox cleanup in the beforeScenario hook of scenarios that have @email tag?

CC @amrita-shrestha

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be done in separate PR

@nabim777
Copy link
Member

Except all the above comments, it LGTM 👍

@prashant-gurung899 prashant-gurung899 force-pushed the test/disable-ocm-notifications branch from 4e6b1fb to 1607e90 Compare February 13, 2025 11:26
@prashant-gurung899 prashant-gurung899 force-pushed the test/disable-ocm-notifications branch 2 times, most recently from 033fa91 to 01a5c77 Compare February 14, 2025 06:25
@prashant-gurung899
Copy link
Contributor Author

Holding this PR until this gets merged : #11011

@prashant-gurung899 prashant-gurung899 force-pushed the test/disable-ocm-notifications branch 3 times, most recently from ff0110c to e7f8213 Compare February 17, 2025 10:12
@prashant-gurung899 prashant-gurung899 force-pushed the test/disable-ocm-notifications branch from e7f8213 to 8a0440f Compare February 18, 2025 04:19
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now let's not block the PRs. we can merge with the tag and do cleanup when we have proper solution for clearing mails.

@saw-jan saw-jan merged commit c4f638a into master Feb 18, 2025
4 checks passed
@saw-jan saw-jan deleted the test/disable-ocm-notifications branch February 18, 2025 06:09
ownclouders pushed a commit that referenced this pull request Feb 18, 2025
[tests-only][full-ci] add test to disable mail and in-app notifications when receiving a federated share
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants