-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests-only][full-ci] add test to disable mail and in-app notifications when receiving a federated share #10973
Conversation
e27a66f
to
ef8f191
Compare
ef8f191
to
4e6b1fb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -1,4 +1,4 @@ | |||
@ocm | |||
@ocm @notification |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is the tag required? and why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes because the email notifications from prior scenarios weren't cleaned up which made CI to fail.
The notifications were related to invitation/collaboration. See build: https://drone.owncloud.com/owncloud/ocis/43375/46/9
[0]=>
│ object(stdClass)#4013 (9) {
│ ["mailbox"]=>
│ string(5) "brian"
│ ["id"]=>
│ string(20) "20250212T063355-0001"
│ ["from"]=>
│ string(47) "Alice Hansen via ownCloud <[email protected]>"
│ ["to"]=>
│ array(1) {
│ [0]=>
│ string(19) "<[email protected]>"
│ }
│ ["subject"]=>
│ string(58) "ScienceMesh: {InitiatorName} wants to collaborate with you"
│ ["date"]=>
│ string(30) "2025-02-12T06:33:55.162188624Z"
│ ["posix-millis"]=>
│ int(1739342035162)
│ ["size"]=>
│ int(2737)
│ ["seen"]=>
│ bool(false)
│ }
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then we should think of better solution again. Maybe do mailbox cleanup in the beforeScenario hook of scenarios that have @email
tag?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be done in separate PR
Except all the above comments, it LGTM 👍 |
4e6b1fb
to
1607e90
Compare
033fa91
to
01a5c77
Compare
Holding this PR until this gets merged : #11011 |
ff0110c
to
e7f8213
Compare
…g federated share Signed-off-by: prashant-gurung899 <[email protected]>
e7f8213
to
8a0440f
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now let's not block the PRs. we can merge with the tag and do cleanup when we have proper solution for clearing mails.
[tests-only][full-ci] add test to disable mail and in-app notifications when receiving a federated share
Description
This PR adds test to disable mail and in-app notification for
Share Received
event for OCM.Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: