Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1033 - In pdf preview, Go to Page don't take user to last page #1034

Merged
merged 2 commits into from
Sep 16, 2021

Conversation

itsaboutcode
Copy link

Description

Issue details mentioned in #1033

Related Issue

#1033

Motivation and Context

Issue #1033have details of this issue

How Has This Been Tested?

I have tested with the steps given in issue#1033

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • Added changelog files for the fixed issues in folder changelog/unreleased

mneuwert and others added 2 commits September 10, 2021 11:39
* First version of the associated domains addition feature in the resign script

* - lines from domains.txt were not correct read
- highlighting output
- fixed wrong provisioning path
- changed version number
- updated readme file

Co-authored-by: Michael Neuwert <[email protected]>
Co-authored-by: Matthias Hühne <[email protected]>
@hosy hosy requested a review from jesmrec September 15, 2021 07:40
@hosy hosy added this to the 11.7.1-Fix milestone Sep 15, 2021
@hosy hosy linked an issue Sep 15, 2021 that may be closed by this pull request
@hosy hosy changed the base branch from master to milestone/11.7.1 September 15, 2021 12:17
@jesmrec
Copy link
Contributor

jesmrec commented Sep 15, 2021

About this one, the issue is totally fixed. Thanks @itsaboutcode !!

But, i see some changes in the list that do not have nothing to do with the current fix (some stuff regarding associated domains and resign script)

Please, take a look or update the branch if needed

CC @hosy

@hosy
Copy link
Collaborator

hosy commented Sep 15, 2021

@jesmrec not sure, why this is not correct viewed by Github. The changes in these three files were made in the master branch last week. It is the same version, like in the milestone/11.7.1 branch. Maybe this is a problem, because the code was forked before. But for me it looks as the same revision, line in the milestone branch.

@jesmrec
Copy link
Contributor

jesmrec commented Sep 15, 2021

if you're sure that the "extra" code is already in milestone/11.7.1 and master, there will not be problems. So, you can go ahead with this.

Same happens in #1030

@jesmrec jesmrec added the Approved by QA Approved by QA label Sep 15, 2021
@hosy hosy merged commit ea67878 into owncloud:milestone/11.7.1 Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved by QA Approved by QA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] In pdf preview, Go to Page don't take user to last page
4 participants