Revert "[feature/new-navigation] New navigation (#1162) [feature/css]…

… CSS Themeing #1194 [feature/gridview] Gridview implementation (v12) (#1195)"

This reverts commit 37d74fc.

.swiftlint.yml

@@ -37,7 +37,6 @@ disabled_rules:
     - comment_spacing
     - unused_closure_parameter
     - nesting
-    - comma
 custom_rules:
   empty_line_after_guard_statement:
     included: ".*\\.swift"

.tx/config

@@ -28,3 +28,4 @@ lang_map = cs_CZ: cs, de_DE: de-DE, en_GB: en-GB, nb_NO: nb-NO, nn_NO: nn-NO, pt
 source_file = fastlane/screenshots/en/title.strings
 source_lang = en
 type = STRINGS
+

.xcode-version

@@ -1 +1 @@
-14.2
+13.4.1

KNOWN_ISSUES.md

@@ -1,4 +1,4 @@
-# Known issues
+#  Known issues in version 12.0 alpha 2
 
 ## WARNING
 
@@ -7,88 +7,44 @@ It should only be used with dedicated test servers, test data - and test devices
 
 ## App
 - in the new browsing experience, some features are not yet available:
+	- a grid view
 	- breadcrumb title
+	- item / folder / usage info at the bottom of lists
 - spaces do not yet show a member count or provide access to a list of members
 - subscription of spaces can't be turned on/off yet
+- the root of spaces-based accounts is not yet shown as hierarchic sidebar
+- support for sharing is widely untested and/or unavailable in the alpha
+- inactivated state of spaces is not yet represented in the UI
+- Copy & Paste allows copying a folder into a subfolder of its own / itself, leading to an infinite cycle
 - handling of detached drives with user data in them (see OCVault.detachedDrives)
-- [x] clicking a file in favorite view doesn't open the viewer (due to lack of context.query - the viewer clases need to be updated to use data sources rather than queries)
-- support for OC10 sharing is incomplete:
-	- lack of actions for accepted shares
-	- federated shares are not yet included in "Shared with me" view
-- spaces support for Shortcuts
-
-Missing:
-- [x] quick access
-- [x] proper iPhone support
-- [ ] static login/branded login UI
-- [x] state restoration
-- [ ] full inline progress reporting when account databases are updated on first login
-- [ ] progress reporting in active connections
-- [x] migration from the Legacy app clarified: the feature was removed
-- [x] iPadOS: opening an account in a new window
-	- [x] by context menu (openAccountInWindow)
-	- [x] by drag and drop (see ServerListTableViewController: UITableViewDragDelegate)
-- [x] account auto connect (also account.auto-connect in ServerListTableViewController) -> no longer necessary, handled by state restoration
-- [x] opening private links (display(itemWithID…:…))
-- [x] account issue handling
-- [x] functional share extension
-- [x] full themeing/branding support
-- [ ] reinstate Key Commands
-
-Jesus:
-- [ ] Presentation view after installing is missing
-- [x] The icon to hide/show the sidebar is missing in portrait mode. -> resolved by BrowserNavigation replacement of UINavigationController
-- [x] Adding an oCIS account with existing custom spaces makes the app freezes and then crashes
-- [x] If an space is browsed and new space image is added in the web client, app crashes
-- [x] "Open in new window" option does not work. It does nothing after clicking
-- [x] I miss the option to "Select All" and "Deselect All" in multiselection
-- [x] "Copy" and "Move" operations show empty folder picker. No way to consolidate.
-- [ ] "Cut"/"Paste" only working in space scope
-- [ ] Upper bar (time, hour, battery level, and so on) is black under dark themes, not visible (fixable?)
-
-Matthias:
-- [x] Selecting an OC10 account's root folder twice results in an empty list -> not reproducible in latest builds
-
-Michael:
-- [x] Account deletion by swipe doesn't work
-- [x] Crash searching for accounts to share with
-- [x] Certificate warning when an account refers to a mix of hostnames
-- [ ] UI rendering picking an account for photo uploads on iPhone: prompt full length, button super-compressed.
+- sync actions that are actually complete are not always cleared from the Status tab until a logout/login
+- dropping an item into its source/origin folder (same view controller) triggers a MOVE that fails
 
 ## File Provider
 - dragging an entire space on top of another starts a full copy of the space, which eventually fails halfway through
 
 ## SDK
+- local storage consumed by spaces that are then deleted or inactivated is not reclaimed
 - pre-population of accounts using infinite PROPFIND is not supported
 
 # Evolution roadmap
-- [ ] collection views
-	- [x] support sidebars / hierarchies, including expanded state, with dynamic updates from data sources
-	- [x] ItemListCell: replace manual composition of info line below name with SegmentView
-		- [x] allows to show different content there, f.ex. Space and Folder in search
-	- [ ] sticky sort / multiselect bar in file lists
-
-- [x] location picker replaces folder picker
-	- [x] supports picking
-		- [x] accounts
-		- [x] spaces
-		- [x] folders
-	- [x] returns an OCLocation
+- collection views
+	- support sidebars / hierarchies, including expanded state, with dynamic updates from data sources
+
+- location picker replaces folder picker
+	- supports picking
+		- accounts
+		- spaces
+		- folders
+	- returns an OCLocation
 	- allow passing "quick locations" to present on top in a group
 	- track and re-offer last-picked / recent locations (via account's KVS)
 	- quick access to personal and other spaces
 	- integrate favorites as group
-	- [x] use for preferences and share extension
-
-- improved bookmark setup / editing
-	- browsing UI for ALL certificates stored in a bookmark's store, not just the primary certificate
 
 - account list
 	- allow grouping accounts (i.e. Home / Work)
-	- [x] replace simple list with modern CollectionViewController-based UI
-
-- available offline
-	- allow creating available offline item policies from smart searches - or directly from the search UI
+	- replace simple list with modern CollectionViewController-based UI
 
 - make sync smarter, f.ex.:
 	- a file that is updated locally multiple times only should be uploaded once, not once for every update
@@ -113,6 +69,4 @@ Michael:
 		- other errors
 			- report to user, drop silently, retry (how often/long?)?
 
-- [x] more expressive "Empty folder" message display, based on new .message item type
-
-- show spinner while recreating a scene via "Open in new window"
+- more expressive "Empty folder" message display, based on new .message item type

Podfile

@@ -0,0 +1,17 @@
+ENV['COCOAPODS_DISABLE_STATS'] = 'true'
+
+target 'ownCloudTests' do
+  project 'ownCloud'
+
+  use_frameworks! # Required for Swift Test Targets only
+  inherit! :search_paths # Required for not double-linking libraries in the app and test targets.
+  pod 'EarlGrey', '~> 1.16'
+end
+
+target 'ownCloudScreenshotsTests' do
+  project 'ownCloud'
+
+  use_frameworks! # Required for Swift Test Targets only
+  inherit! :search_paths # Required for not double-linking libraries in the app and test targets.
+  pod 'EarlGrey', '~> 1.16'
+end

Podfile.lock

@@ -0,0 +1,16 @@
+PODS:
+  - EarlGrey (1.16.0)
+
+DEPENDENCIES:
+  - EarlGrey (~> 1.16)
+
+SPEC REPOS:
+  trunk:
+    - EarlGrey
+
+SPEC CHECKSUMS:
+  EarlGrey: 455e5597ae5ccaca92cd46b81d8b25cacec060a1
+
+PODFILE CHECKSUM: 9075b8f92281024401a0039c3477c9a16650b092
+
+COCOAPODS: 1.10.0