Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefill the og:description with the page title #406

Merged
merged 1 commit into from
Jan 18, 2022

Conversation

mmattel
Copy link
Collaborator

@mmattel mmattel commented Jan 18, 2022

The page description was empty in 99% of the cases, causing hint notes under the image to display a desctiption is missing. To temporarily fix this, the page title is added which is present in all cases.

On a longer view, this should be changed to a real brief description which then could be reused for google search. See details in the referenced issue #396 (Revise head-meta-opengraph.hbs)

@xoxys
Copy link
Contributor

xoxys commented Jan 18, 2022

Why not make it conditional and use the description if exists otherwise dont include the og property at all? This way descriptions can be added step by step without touching the theme again?

@mmattel
Copy link
Collaborator Author

mmattel commented Jan 18, 2022

Why not make it conditional and use the description if exists otherwise dont include the og property at all

This is possibe but does not bring any additional results.
The description, which is an attribute to be manually filled with content per page, is defacto not present. I have described the correct way to do this in the referenced issue - which will help us to catch two flies with one hit.

@mmattel mmattel merged commit 7c85df9 into master Jan 18, 2022
@delete-merged-branch delete-merged-branch bot deleted the prefill_og_description branch January 18, 2022 12:28
@xoxys
Copy link
Contributor

xoxys commented Jan 18, 2022

Now you render the title twice, which doesn't make it better 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants