Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] [full-ci] getPersonalSpaceIdForUser from webdav propfind #39751

Merged

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Feb 4, 2022

Description

See the comments and code for details. When on oCIS, /graph/v1.0/me/drives endpoint exists and returns a list of spaces, and the code parses that list like it previously did and finds the personal space id for the user.

If that nice endpoint does not exist, then the code does a PROPFIND on the webdav root of the user. On reva (at least) the response contains oc:id which id a base64-encoded value that happens to include the personal space id. See the code for how the personal space id is reconstructed.

This allows us to test using the personal space id to access the files of a user. That allows us to verify what webdav space scenarios pass, or fail, in reva. That will be helpful when fixing stuff - a developer can try to make the tests pass.

Fixed issue #39617

How Has This Been Tested?

CI passes here in core
oCIS CI passes in owncloud/ocis#3077 - there is no change there because the test code running there will not use the new webdav propfind way to find the personal space id.

cs3org/rev CI passes in cs3org/reva#2505 - that starts running personalSpace API tests in reva. It makes use of the new test code in this PR, and it adds the failing personalSpaces tests to expected-failures.

After merge this PR, I will switch those oCIS and reva PRs to use the new master commit id, and then we can also merge them.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants