Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci][tests-only] add spaces webdav variant for favorites api features #39666

Closed
wants to merge 1 commit into from
Closed

[full-ci][tests-only] add spaces webdav variant for favorites api features #39666

wants to merge 1 commit into from

Conversation

amrita-shrestha
Copy link
Contributor

@amrita-shrestha amrita-shrestha commented Jan 10, 2022 •
edited
Loading

Description

This PR adds tests related to spaces WebDAV in apiFavorite folder.

Related Issue

How Has This Been Tested?

  • Locally
  • CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

@amrita-shrestha amrita-shrestha force-pushed the fix-spaces-webDAV-path branch 2 times, most recently from 640b0e9 to af18f6c Compare January 10, 2022 07:17
@amrita-shrestha amrita-shrestha mentioned this pull request Jan 10, 2022
Closed
This was referenced Jan 10, 2022
Closed
Closed
@phil-davis phil-davis force-pushed the fix-spaces-webDAV-path branch from 82838a6 to af18f6c Compare January 10, 2022 10:08
@amrita-shrestha amrita-shrestha force-pushed the fix-spaces-webDAV-path branch 3 times, most recently from 9a04ef1 to dd3bc4a Compare January 11, 2022 08:20
@amrita-shrestha amrita-shrestha mentioned this pull request Jan 11, 2022
Merged
5 tasks
@kiranparajuli589 kiranparajuli589 changed the title [full-ci][tests-only]Fixes for spaces webDav path implementation [full-ci][tests-only] add spaces webdav variant for favorites api features Jan 11, 2022
@amrita-shrestha amrita-shrestha force-pushed the fix-spaces-webDAV-path branch 3 times, most recently from f9644cc to 0b8f07a Compare January 12, 2022 06:19
@amrita-shrestha amrita-shrestha self-assigned this Jan 12, 2022
@amrita-shrestha amrita-shrestha requested review from Talank, saw-jan, SwikritiT and kiranparajuli589 and removed request for Talank, SwikritiT and saw-jan January 12, 2022 06:58
kiranparajuli589
kiranparajuli589 reviewed Jan 12, 2022
View reviewed changes
Copy link
Contributor

@kiranparajuli589 kiranparajuli589 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@amrita-shrestha
Copy link
Contributor Author

moved to #39686 to not use the fork branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiranparajuli589 kiranparajuli589 kiranparajuli589 left review comments

Assignees

@amrita-shrestha amrita-shrestha

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amrita-shrestha @kiranparajuli589