Fix error rendering category pages #1045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The build problem turned out to be a bad version of selenium-webdrivers. Only now, github actions has an expired certificate error on every version of Ruby except 3.1. 😭 It's not my day. |
|
Here's the related issue: |
|
@brian-kephart, it's not only your day, it's your week! You're the great bug-fixer hero this week!!! 💟 I only was looking at these 500 errors and thinking about the weekend to see what's happening :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RuboCop rearranged a line, causing a bug because a local variable was referenced before it was defined. It was undefined in the previous version as well, but the code didn't fail because the reference was in the line assigning the variable. So, we were getting away with something ill-advised until RuboCop altered it.
Currently the CI build is failing, but this appears to be something to do with GitHub actions. The tests pass locally. I re-ran a CI job that passed a few days ago and it failed as well, leading me to believe this is a GitHub issue.