Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(venom): Replace backslashes with forward slashes for Windows #753

Merged
merged 14 commits into from
Dec 22, 2023

Conversation

ivan-velasco
Copy link
Contributor

@ivan-velasco ivan-velasco commented Dec 4, 2023

Close #750

@ivan-velasco ivan-velasco changed the title Fix/bash shell windows fix(venom): bash shell forward slashes windows Dec 5, 2023
@ivan-velasco ivan-velasco changed the title fix(venom): bash shell forward slashes windows fix(venom): Replace backslashes with forward slashes for Windows Dec 5, 2023
@ivan-velasco ivan-velasco marked this pull request as draft December 5, 2023 09:06
…is is particularly relevant when running in Git Bash to prevent errors during the conversion of YAML to JSON.

Signed-off-by: Ivan Velasco <[email protected]>
@ivan-velasco ivan-velasco marked this pull request as ready for review December 5, 2023 17:23
@yesnault
Copy link
Member

Hi @ivan-velasco , yes, much better here than in parseTestCase func. Thank you for this proposal.

@yesnault yesnault merged commit 8e28aed into ovh:master Dec 22, 2023
2 checks passed
@ivan-velasco ivan-velasco deleted the fix/bash-shell-windows branch April 25, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Running venom on windows using git bash shell
2 participants