Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding test in the root package in order to test the run command #733

Merged
merged 3 commits into from
Nov 29, 2023

Conversation

fokion
Copy link
Contributor

@fokion fokion commented Oct 21, 2023

Adding test for the run command , running local tests that we currently only run in E2E.

@fokion fokion changed the title adding test in the root package in order to test the run command WIP-adding test in the root package in order to test the run command Oct 21, 2023
@fokion fokion marked this pull request as draft October 21, 2023 21:30
@fokion fokion changed the title WIP-adding test in the root package in order to test the run command Adding test in the root package in order to test the run command Oct 21, 2023
@fokion fokion marked this pull request as ready for review October 21, 2023 21:57
@fokion
Copy link
Contributor Author

fokion commented Oct 23, 2023

#708

Copy link
Member

@yesnault yesnault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the existing IsTest variable instead off adding a new env var VENOM_TEST_MODE and InTestMode attribute.

venom.go Outdated Show resolved Hide resolved
venom.go Outdated Show resolved Hide resolved
cmd/venom/run/cmd.go Outdated Show resolved Hide resolved
Signed-off-by: Fokion Sotiropoulos <[email protected]>
@fokion fokion requested a review from yesnault October 23, 2023 18:31
@yesnault yesnault merged commit 75a3d67 into ovh:master Nov 29, 2023
2 checks passed
@fokion fokion deleted the feat/adding-tests-toplevel branch November 29, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants