Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

working on ShouldMatchRegex #674

Merged
merged 1 commit into from
Jun 1, 2023
Merged

working on ShouldMatchRegex #674

merged 1 commit into from
Jun 1, 2023

Conversation

fokion
Copy link
Contributor

@fokion fokion commented May 31, 2023

#643 working on having that ability

  • Created a new keyword called ShouldMatchRegex
  • Updated documentation
  • Added tests

@fokion
working on ShouldMatchRegex
d324612 
Signed-off-by: Fokion Sotiropoulos <[email protected]>
yesnault
yesnault approved these changes Jun 1, 2023
View reviewed changes
Copy link
Member

@yesnault yesnault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@ovh-cds
Copy link
Collaborator

ovh-cds commented Jun 1, 2023

CDS Report build-venom-a#51.0 ✘

  • Build
    • Build ✔
    • Unit Tests ✔
  • Tests
    • Acceptance Tests ✘

@yesnault yesnault merged commit d21895e into ovh:master Jun 1, 2023
@fokion fokion deleted the feat/assertion-regex branch June 1, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yesnault yesnault yesnault approved these changes

@fsamin fsamin fsamin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fokion @ovh-cds @yesnault @fsamin