Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding secrets field and refactoring the logging process. #667

Merged
merged 5 commits into from
Jul 24, 2023

Conversation

fokion
Copy link
Contributor

@fokion fokion commented May 12, 2023

Adding secrets in the context and creating a function that we can call to hide sensitive data

Add the ability to mark variables as secrets in the testsuite so that the venom.log does not show them

#476

@fokion fokion marked this pull request as draft May 12, 2023 22:42
@fokion fokion changed the title wip - Adding secrets field and refactoring the logging process. Adding secrets field and refactoring the logging process. May 12, 2023
@fokion
Copy link
Contributor Author

fokion commented May 17, 2023

Is this approach on the right track @yesnault , @fsamin ?

@yesnault
Copy link
Member

Is this approach on the right track @yesnault , @fsamin ?

LGTM @fokion , thank you!

@fokion fokion force-pushed the feat/remove-secrets branch 4 times, most recently from d5a444c to c28e105 Compare June 5, 2023 20:53
@fokion fokion marked this pull request as ready for review June 5, 2023 20:53
@fokion
Copy link
Contributor Author

fokion commented Jun 7, 2023

let me know if that can be merged :)

@fokion
Copy link
Contributor Author

fokion commented Jul 17, 2023

Hey @yesnault , @fsamin is there an eta for merging this PR?

…ets in the context and creating a function that we can call to hide sensitive data

Add the ability to set secrets in the testsuite

Signed-off-by: Fokion Sotiropoulos <[email protected]>
@yesnault yesnault merged commit 5b319da into ovh:master Jul 24, 2023
1 check passed
fokion added a commit to fokion/venom that referenced this pull request Aug 1, 2023
)

* adding secrets field and refactoring the logging process. Adding secrets in the context and creating a function that we can call to hide sensitive data

Signed-off-by: Fokion Sotiropoulos <[email protected]>
Co-authored-by: Yvonnick Esnault <[email protected]>
Signed-off-by: Fokion Sotiropoulos <[email protected]>
ivan-velasco pushed a commit to socotra/venom that referenced this pull request Sep 20, 2023
)

* adding secrets field and refactoring the logging process. Adding secrets in the context and creating a function that we can call to hide sensitive data

Signed-off-by: Fokion Sotiropoulos <[email protected]>
Co-authored-by: Yvonnick Esnault <[email protected]>
Signed-off-by: Ivan Velasco <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants