fix(http): preserve BodyFile absolute path

[fsamin]

Signed-off-by: François Samin [email protected]

[ovh-cds]

CDS Report build-venom-a#1087.0 ✘

• Build
  • Build ✔
  • Unit Tests ✔
• Tests
  • Acceptance Tests ✘

[ovh-cds]

CDS Report build-venom-a#1092.0 ✘

• Build
  • Build ✔
  • Unit Tests ✔
• Tests
  • Acceptance Tests ✘

[ivan-velasco]

I have tested this out and fails to work when we set lib_dir in .venomrc to root directory because the check done is for an absolute path. If the absolute path is set in configuration it works, but this would change per dev machine and testing envs.
e.g.
.venomrc

lib_dir: lib

http.go

if !filepath.IsAbs(e.BodyFile)

The test fails because no body is attached to the request.

I tested using an additional check !filepath.IsLocal(e.BodyFile) and fixes the issue, but causes problems in test suites.
Suggestion would be the following in func initFromReaderConfigFile
cmd.go

	if configFileData.LibDir != nil {
		libDir = *configFileData.LibDir
		if absPath, err := filepath.Abs(libDir); err == nil {
			libDir = absPath
		} else {
			return err
		}
	}

Tested and confirmed this works well.

[ovh-cds]

CDS Report build-venom-a#1113.0 ✘

• Build
  • Build ✔
  • Unit Tests ✔
• Tests
  • Acceptance Tests ✘

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

100.0% Coverage
0.0% Duplication

[ovh-cds]

CDS Report build-venom-a#15.0 ■

• Build
  • Build ✔
  • Unit Tests ✔
• Tests
  • Acceptance Tests ■

[ovh-cds]

CDS Report build-venom-a#15.0 ■

• Build
  • Build ✔
  • Unit Tests ✔
• Tests
  • Acceptance Tests ■