Executor Web - Refactoring #551

kevinramage · 2022-05-12T13:36:01Z

Change the web driver client to a new one (now, agouti is now maintain).

Facilitate integration with proxy, headless
Improve log management (Possibility to see REST call between web driver and browser in debug mode)
Improve error management
Add new synchronisation features
Add Javascript code feature
Compatible with W3C

fsamin · 2022-05-19T08:21:04Z

Hi,
Your branch has some conflict, could you rebase it ?
It seems that the integration test tests/web.yml is failing with a panic:

• TestSuite Web (./web.yml)
 	• TestCase-Get-URL-and-check-titlepanic: runtime error: invalid memory address or nil pointer dereference
goroutine 19 [running]:
runtime/debug.Stack()
	/usr/local/go/src/runtime/debug/stack.go:24 +0x65
github.com/confluentinc/bincover.RunTest.func1()
	/go/pkg/mod/github.com/confluentinc/[email protected]/instrument_bin.go:84 +0x39
panic({0x12fe3e0, 0x1db9010})
	/usr/local/go/src/runtime/panic.go:1038 +0x215
github.com/ovh/venom/executors/web.Executor.Run({{0x0, {0x0, 0x0, 0x0}, {0x0, 0x0}, 0x0, 0x0, 0x0, 0x0, ...}, ...}, ...)
	/workspace/executors/web/web.go:152 +0xc6
github.com/ovh/venom.executor.Run({{0x15ddcc0, 0xc000342e10}, {0xc0001b1c4a, 0x3}, 0x0, {0x1ff49e8, 0x0, 0x0}, 0x0, 0x0, ...}, ...)
	/workspace/types_executor.go:130 +0x5c
github.com/ovh/venom.(*Venom).runTestStepExecutor(0xc000342b40, {0x15f9340, 0xc0024f0bd0}, {0x1614820, 0xc001194d80}, 0xc0002c6c00, 0xc0024f04b0)
	/workspace/process_teststep.go:143 +0x24b
github.com/ovh/venom.(*Venom).RunTestStep(0xc000342b40, {0x15f9340, 0xc0024f0ba0}, {0x1614820, 0xc001194d80}, 0xc0002c6c00, 0x2, 0xc0024f04b0)
	/workspace/process_teststep.go:36 +0x290
github.com/ovh/venom.(*Venom).runTestSteps(0xc000ead288, {0x15f9340, 0xc001bff140}, 0xc0002c6c00)
	/workspace/process_testcase.go:252 +0xf28
github.com/ovh/venom.(*Venom).runTestCase(0x145107b, {0x15f9340, 0xc001bff050}, 0xc000412aa8, 0xc0002c6c00)
	/workspace/process_testcase.go:138 +0x4d1
github.com/ovh/venom.(*Venom).runTestCases(0xc000342b40, {0x15f9340, 0xc001bff050}, 0xc000412aa8)
	/workspace/process_testsuite.go:87 +0x405
github.com/ovh/venom.(*Venom).runTestSuite(0xc000342b40, {0x15f92d0, 0xc0000de000}, 0xc000412aa8)
	/workspace/process_testsuite.go:67 +0xbaa
github.com/ovh/venom.(*Venom).Process(0xc000342b40, {0x15f92d0, 0xc0000de000}, {0xc0003c2c00, 0xc0000de000, 0xc000396600})
	/workspace/process.go:153 +0x145
github.com/ovh/venom/cmd/venom/run.glob..func2(0x1dc6260, {0xc0003c2c00, 0x5c, 0x60})
	/workspace/cmd/venom/run/cmd.go:402 +0x785
github.com/spf13/cobra.(*Command).execute(0x1dc6260, {0xc0003c2600, 0x5c, 0x60})
	/go/pkg/mod/github.com/spf13/[email protected]/command.go:850 +0x60e
github.com/spf13/cobra.(*Command).ExecuteC(0x1dc5fc0)
	/go/pkg/mod/github.com/spf13/[email protected]/command.go:958 +0x3ad
github.com/spf13/cobra.(*Command).Execute(...)
	/go/pkg/mod/github.com/spf13/[email protected]/command.go:895
github.com/ovh/venom/cmd/venom.main()
	/workspace/cmd/venom/main.go:20 +0x31
github.com/confluentinc/bincover.RunTest(0x14d0890)
	/go/pkg/mod/github.com/confluentinc/[email protected]/instrument_bin.go:93 +0x21b
github.com/ovh/venom/cmd/venom.TestBincoverRunMain(0x0)
	/workspace/cmd/venom/main_test.go:12 +0x25
testing.tRunner(0xc00025bd40, 0x14d0888)
	/usr/local/go/src/testing/testing.go:1259 +0x102
created by testing.(*T).Run
	/usr/local/go/src/testing/testing.go:1306 +0x35a

…to web-refacto # Conflicts: executors/web/web.go go.mod go.sum

yesnault · 2022-08-03T16:01:10Z

Hi @kevinramage , thank you for this refactoring.

I didn't manage to run the example:

./venom run w.yml
	  [trac] writing venom.25.log
 • TestSuite Web (w.yml)
 	• TestCase-Google-searchStarting ChromeDriver 104.0.5112.79 (3cf3e8c8a07d104b9e1260c910efb8f383285dc5-refs/branch-heads/5112@{#1307}) on port 9515
Only local connections are allowed.
Please see https://chromedriver.chromium.org/security-considerations for suggestions on keeping ChromeDriver safe.
ChromeDriver was started successfully.
 FAILURE
Unable create new session: an error occured during create session action: an error occured during post request: session - Invalid status code 500
Unable to start web driver: an error occured during session starting: port 9515 not available
Unable to start web driver: an error occured during session starting: port 9515 not available
Unable to start web driver: an error occured during session starting: port 9515 not available

with the testsuite (from readme)

name: TestSuite Web
vars:
  web:
    driver: chrome
    width: 1920
    height: 1080
    args:
    - 'browser-test'
    prefs:
      profile.default_content_settings.popups: 0
      profile.default_content_setting_values.notifications: 1
    timeout: 60
    debug: true
testcases:
- name: TestCase Google search
  steps:
  - type: web
    action:
      navigate:
        url: https://www.google.fr
    assertions:
    - result.title ShouldEqual Google
    - result.url ShouldEqual https://www.google.fr
  - type: web
    action:
      find: input[name="q"]
    assertions:
     - result.find ShouldEqual 1
  - type: web
    action:
      fill:
      - find: input[name="q"]
        text: "venom ovh"
  - type: web
    action:
      click:
        find: input[value="Recherche Google"]
        wait: 1
    screenshot: googlesearch.png

did I miss something somewhere?

kevinramage · 2022-08-22T14:10:01Z

Hello @yesnault ,

You probably have an application running on port 9515, can you check this point with a command like "ps -ef" or "netstat -ano" ?
I update example code provided in README

Regards

buger · 2022-09-01T14:34:02Z

Looks really nice! Would love to see it merged!

kevinramage · 2022-10-12T20:34:24Z

Hi @yesnault, do you always have an issue with port unavailable ?

yesnault · 2022-10-18T15:27:23Z

chromedriver updated, I have another err now:

❯ ./venom run w.yml
	  [trac] writing venom.6.log
 • TestSuite Web (w.yml)
 	• TestCase-Google-searchStarting ChromeDriver 106.0.5249.61 (511755355844955cd3e264779baf0dd38212a4d0-refs/branch-heads/5249@{#569}) on port 58636
Only local connections are allowed.
Please see https://chromedriver.chromium.org/security-considerations for suggestions on keeping ChromeDriver safe.
ChromeDriver was started successfully.
Starting ChromeDriver 106.0.5249.61 (511755355844955cd3e264779baf0dd38212a4d0-refs/branch-heads/5249@{#569}) on port 58640
Only local connections are allowed.
Please see https://chromedriver.chromium.org/security-considerations for suggestions on keeping ChromeDriver safe.
ChromeDriver was started successfully.
Starting ChromeDriver 106.0.5249.61 (511755355844955cd3e264779baf0dd38212a4d0-refs/branch-heads/5249@{#569}) on port 58644
Only local connections are allowed.
Please see https://chromedriver.chromium.org/security-considerations for suggestions on keeping ChromeDriver safe.
ChromeDriver was started successfully.
Starting ChromeDriver 106.0.5249.61 (511755355844955cd3e264779baf0dd38212a4d0-refs/branch-heads/5249@{#569}) on port 58648
Only local connections are allowed.
Please see https://chromedriver.chromium.org/security-considerations for suggestions on keeping ChromeDriver safe.
ChromeDriver was started successfully.
 FAIL
Unable to resize the page: failed to retrieve window: request unsuccessful: invalid session id
Unable to resize the page: failed to retrieve window: request unsuccessful: invalid session id
Unable to resize the page: failed to retrieve window: request unsuccessful: invalid session id
Unable to resize the page: failed to retrieve window: request unsuccessful: invalid session id
final status: FAIL

kevinramage · 2022-10-25T20:12:47Z

Hello @yesnault, Thanks for this feedback
I try to reproduce the issue and I don't reproduce it in my side
Can you set log level to Debug (Set web.debug to true OR set web.logLevel to DEBUG) and check file named venom.x.log ?
In this refacto, you can see all rest calls. With the rest calls, we can in details the root cause of this issue.

blaryjp · 2023-03-26T12:23:46Z

@yesnault : do you use the same version between chromedriver and chromium?

some useful links:

https://chromedriver.chromium.org/downloads/version-selection
https://omahaproxy.appspot.com/ (to find a revision by version)

kevinramage · 2023-04-21T20:01:51Z

@yesnault
I retry code, I can run web tests in my side.
Do yo you always have the issue ?
Do you have the good version of the driver ?

yesnault · 2023-04-25T09:02:36Z

Hi @kevinramage, I'll recheck with @blaryjp hints this week with same chromium and chrome driver version.

yesnault · 2023-04-25T09:47:05Z

@kevinramage ok, so the error is now clear:

Apr 25 11:32:31.907 [DEBU] Response body: {"value":{"error":"unknown error","message":"unknown error: cannot find Chrome binary","stacktrace":"0   chromedriver                        0x0000000109a13ae8 chromedriver + 4958952\n1   chromedriver                        0x0000000109a0b7b3 chromedriver + 4925363\n2   chromedriver                        0x00000001095cd1d6 chromedriver + 475606\n3   chromedriver                        0x00000001095f755c chromedriver + 648540\n4   chromedriver                        0x00000001095f5069 chromedriver + 639081\n5   chromedriver                        0x00000001096406e9 chromedriver + 947945\n6   chromedriver                        0x000000010963fa7f chromedriver + 944767\n7   chromedriver                        0x00000001096369e3 chromedriver + 907747\n8   chromedriver                        0x0000000109600aef chromedriver + 686831\n9   chromedriver                        0x000000010960200e chromedriver + 692238\n10  chromedriver                        0x00000001099cf9ad chromedriver + 468...

I don't have Chrome (but chromium ok).
In you lib, can you add the possibility to specify the chromium / chromium installation on the chromedriver options (options.setBinary, cf. https://sites.google.com/a/chromium.org/chromedriver/capabilities#TOC-Using-a-Chrome-executable-in-a-non-standard-location) ?
Do you test it on osx too ?

Thank you,

blaryjp · 2023-04-26T09:58:16Z

Thank you for the investigation.

I agree with Yvonnick about the possibility to specify the CHROME_PATH/CHROMIUM_PATH.
Is it also possible to pass the CHROMEDRIVER_PATH also? I've it in a custom folder on my side.

kevinramage · 2023-04-26T11:23:38Z

Thanks for this feedback, I will check soon this point

kevinramage · 2023-05-01T19:07:57Z

Hi @yesnault @blaryjp
I see your merge request to "kevinramage-web-refacto" branch, I add corrections in this PR #663
I add options to set browser binary, driver binary and driver port.
VenomWeb dependency manage a new restriction about relative path.
Regards,

backport from ovh#663

yesnault · 2023-05-02T14:17:48Z

I backported from #663 executor web updates (closing #663, not rebase master)

yesnault · 2023-05-02T15:31:16Z

@kevinramage @blaryjp It's ok now, thank you.

❯ venom run -v web.yml
	  [trac] writing venom.2.log
 • TestSuite Web (web.yml)
 	• TestCase-Get-URL-and-check-title
 		• web PASS
 		• web PASS
 		• web PASS
 		• web PASS
	  	  [info] title is '' (web.yml:24)
final status: PASS

I check integration test

yesnault · 2023-05-02T15:38:48Z

@kevinramage @blaryjp thank you, it's ok now

❯ venom run -v web.yml
	  [trac] writing venom.2.log
 • TestSuite Web (web.yml)
 	• TestCase-Get-URL-and-check-title
 		• web PASS
 		• web PASS
 		• web PASS
 		• web PASS
	  	  [info] title is '' (web.yml:24)
final status: PASS

Change the web driver client to a new one (now, agouti is now maintain). - Facilitate integration with proxy, headless - Improve log management (Possibility to see REST call between web driver and browser in debug mode) - Improve error management - Add new synchronisation features - Add Javascript code feature - Compatible with W3C Signed-off-by: Ivan Velasco <[email protected]>

kevinramage added 3 commits April 6, 2022 23:04

Init refactoring

0b336db

Implement new web driver client

267f089

Change documentation

2fa66bd

fsamin self-requested a review May 19, 2022 08:21

kevinramage added 5 commits May 29, 2022 20:49

Init refactoring

ebc1abc

Implement new web driver client

47627eb

Change documentation

03aa9bc

Merge branch 'web-refacto' of https://github.com/kevinramage/venom in…

1983ab4

…to web-refacto # Conflicts: executors/web/web.go go.mod go.sum

Change web driver to gecko (phantomjs is not maintain)

69fc07a

Update example in documentation

19d2011

Merge branch 'master' into web-refacto

b026377

yesnault and others added 4 commits May 2, 2023 16:13

Merge branch 'master' into web-refacto

ee48a1f

Update web.go

cbf7ca3

backport from ovh#663

Update types.go

cf2ae4f

backport from ovh#663

Update README.md

d0c9911

backport from ovh#663

yesnault mentioned this pull request May 2, 2023

Add binary, driverBinary and driverPort options #663

Closed

ovh deleted a comment from ovh-cds May 3, 2023

Merge branch 'master' into web-refacto

20c85b3

yesnault merged commit 21d29a7 into ovh:master May 4, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Executor Web - Refactoring #551

Executor Web - Refactoring #551

kevinramage commented May 12, 2022

fsamin commented May 19, 2022

yesnault commented Aug 3, 2022

kevinramage commented Aug 22, 2022

buger commented Sep 1, 2022

kevinramage commented Oct 12, 2022

yesnault commented Oct 18, 2022

kevinramage commented Oct 25, 2022

blaryjp commented Mar 26, 2023

kevinramage commented Apr 21, 2023

yesnault commented Apr 25, 2023

yesnault commented Apr 25, 2023

blaryjp commented Apr 26, 2023

kevinramage commented Apr 26, 2023

kevinramage commented May 1, 2023

yesnault commented May 2, 2023

yesnault commented May 2, 2023

yesnault commented May 2, 2023

Executor Web - Refactoring #551

Executor Web - Refactoring #551

Conversation

kevinramage commented May 12, 2022

fsamin commented May 19, 2022

yesnault commented Aug 3, 2022

kevinramage commented Aug 22, 2022

buger commented Sep 1, 2022

kevinramage commented Oct 12, 2022

yesnault commented Oct 18, 2022

kevinramage commented Oct 25, 2022

blaryjp commented Mar 26, 2023

kevinramage commented Apr 21, 2023

yesnault commented Apr 25, 2023

yesnault commented Apr 25, 2023

blaryjp commented Apr 26, 2023

kevinramage commented Apr 26, 2023

kevinramage commented May 1, 2023

yesnault commented May 2, 2023

yesnault commented May 2, 2023

yesnault commented May 2, 2023