Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(executor/sql): removing odbc for now #300

Merged
merged 1 commit into from
Nov 17, 2020
Merged

fix(executor/sql): removing odbc for now #300

merged 1 commit into from
Nov 17, 2020

Conversation

yesnault
Copy link
Member

until executor as plugin is available, this will let everybody compile
and run venom without installing unixodbc library.

Signed-off-by: Yvonnick Esnault [email protected]

until executor as plugin is available, this will let everybody compile
and run venom without installing unixodbc library.

Signed-off-by: Yvonnick Esnault <[email protected]>
@ovh-cds
Copy link
Collaborator

ovh-cds commented Nov 16, 2020

CDS Report build-venom#281.0 ✘

  • Build
    • Build ✔
  • Tests
    • Acceptance Tests ✘
    • Lib Unit Tests ✔

@yesnault
Copy link
Member Author

@kevinramage FYI, we had to remove odbc for now, to let users run venom without having unixodbc installed. We'll add support to go plugin soon (should work on it this week), this will let venom to have a executor odbc as .so file, that users can load only if they need it.

@yesnault yesnault merged commit 687d77c into master Nov 17, 2020
@yesnault yesnault deleted the ye-compile branch December 1, 2020 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants