Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added support for headers when calling ovh.Client.raw_call #84

Merged
merged 1 commit into from
Mar 14, 2022

Conversation

geoffreybauduin
Copy link
Member

This feature aims at making available the use of headers while calling the OVH API.
The original behavior is preserved, as the signature changes with the introduction
of a non-mandatory parameter "header", which is None by default.
Added a piece of documentation to warn the user about the possbility
to have some headers being rewritten by the Client engine.

Signed-off-by: Geoffrey Bauduin [email protected]

ovh/client.py Show resolved Hide resolved
ovh/client.py Outdated Show resolved Hide resolved
@LukeMarlin
Copy link

As a more general comment, what's your use case for this? Is it worth mentioning in the README?

@rbeuque74 rbeuque74 self-requested a review December 31, 2019 15:50
ovh/client.py Outdated Show resolved Hide resolved
This feature aims at making available the use of headers while calling the OVH API.
The original behavior is preserved, as the signature changes with the introduction
of a non-mandatory parameter "header", which is None by default.
Added a piece of documentation to warn the user about the possbility
to have some headers being rewritten by the Client engine.

Signed-off-by: Geoffrey Bauduin <[email protected]>
@rbeuque74 rbeuque74 merged commit 6b85e1b into master Mar 14, 2022
@rbeuque74 rbeuque74 deleted the support-headers branch March 14, 2022 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants