-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix python 3.10 compatibility #108
Conversation
* vendored requests not compatible with python 3.10 * vendored requests added because of disable pyopenssl for ovh to fix "EPIPE" that seems to be fixed by requests 2.11.0 * so vendored requests is dropped and replaced by a adequate requests dependency * all vendored requests references are dropped * changelog proposal for next version
Hi @rbeuque74 apologies for pinging you directly but since you're one of the maintainers here, I wanted to ask if there is any progress with this PR? I'm currently in the progress of adding ovh to conda-forge and the vendored requests is making this quite difficult. Additionally, it is missing some bug fixes that are available in newer versions so it would be great if this could be merged? |
@rbeuque74 @geoffreybauduin Gentle ping again |
Thanks @geoffreybauduin If you have the necessary rights, would you mind merging this and making a new release? |
@BastianZim while I would be happy to move forward and help you fix this issue, you are now in the hands of @rbeuque74 to move forward. I'll contact him and see how we can set this up in the near future. |
Great, thank you! |
ovh/client.py
Outdated
pass | ||
from requests import request, Session | ||
from requests.packages import urllib3 | ||
from requests.exceptions import RequestException | ||
|
||
# Disable SNI related Warning. The API does not rely on it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# Disable SNI related Warning. The API does not rely on it |
I will have to remove that one, as the API do now rely on it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rbeuque74 Thanks for the review. Does that need to be done in this PR or can this be merged?
Sorry for asking so much, I would just need this PR downstream. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Il push a new commit to remove comment and SNI warning deactivation.
We are currently adapting our CI pipeline, since this repository was still using travis-ci.org, in order to be able to push a new version to pypi. Once it is setup we will move forward. Sorry for the delay |
Signed-off-by: Romain Beuque <[email protected]>
Setup of the CI pipeline took longer as expected, as we stumble upon a lot of incompatibilities due to build libraries not compatible anymore with Python 2.7, 3.4 and 3.5. |
Thanks for your contribution btw 🥇 |
that seems to be fixed by requests 2.11.0
dependency
This is an alternate proposal to handle python 3.10 compatibility. It implements my proposal done on #106 to drop vendored requests as it seems to me that an updated requests library is a better way to fix an pyopenssl pooling issue.
Fix the python 3.10 issue: