feat(oui-collapsible): collapsible component addition #197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ganeshkumar1989
requested review from
AxelPeter,
neolitec,
rfougier and
whispyy
This was referenced Apr 25, 2018
neolitec
suggested changes
Apr 25, 2018
Contributor
neolitec
left a comment
neolitec
left a comment
There was a problem hiding this comment.
In collapsed state, the bottom border of the body is visible.
Contributor
Author
|
@neolitec , the body border in collapsed state has been removed |
AxelPeter
approved these changes
Apr 26, 2018
| @import './_variables'; | ||
|
|
||
| #oui { | ||
| .collapsible( |
Contributor
There was a problem hiding this comment.
(optional) You can put your style directly in the main file. We stopped structuring our styles with this kind of mixin (called once) :)
Here for example: https://github.com/ovh-ux/ovh-ui-kit/blob/master/packages/oui-stepper/stepper.less
Contributor
Author
There was a problem hiding this comment.
Sure. Thanks for the comment. I will follow this from my next PR onwards :)
Update: This change has been done :)
whispyy
approved these changes
May 17, 2018
FredericEspiau
approved these changes
May 18, 2018
FredericEspiau
approved these changes
May 18, 2018
FredericEspiau
approved these changes
May 18, 2018
added 7 commits
May 30, 2018 15:40
AxelPeter
force-pushed
the
feature/oui-collapsible
branch
2 times, most recently
from
5957a35 to
984b772
Compare
AxelPeter
force-pushed
the
feature/oui-collapsible
branch
from
984b772 to
043186f
Compare
neolitec
pushed a commit
that referenced
this pull request
Jun 21, 2018
* feat(oui-collapsible): addition of collapsible component * fix(oui-collapsible): max-height fix for ie 11 * fix(oui-collapsible): oui-color-charlotte reference updated * fix(oui-collapsible): body border fix * fix(oui-collapsible): accessibility fixes * fix(oui-collapsible): header replaced with button * fix(oui-collapsible): fixed border animation * fix(oui-collapsible): fix collapse animation
AxelPeter
pushed a commit
that referenced
this pull request
Jun 28, 2018
* feat(oui-collapsible): addition of collapsible component * fix(oui-collapsible): max-height fix for ie 11 * fix(oui-collapsible): oui-color-charlotte reference updated * fix(oui-collapsible): body border fix * fix(oui-collapsible): accessibility fixes * fix(oui-collapsible): header replaced with button * fix(oui-collapsible): fixed border animation * fix(oui-collapsible): fix collapse animation
AxelPeter
pushed a commit
that referenced
this pull request
Jun 28, 2018
* feat(oui-collapsible): addition of collapsible component * fix(oui-collapsible): max-height fix for ie 11 * fix(oui-collapsible): oui-color-charlotte reference updated * fix(oui-collapsible): body border fix * fix(oui-collapsible): accessibility fixes * fix(oui-collapsible): header replaced with button * fix(oui-collapsible): fixed border animation * fix(oui-collapsible): fix collapse animation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UU-836
Linked to
ovh-ux/ovh-ui-angular#173
ovh-ux/ovh-ui-kit-documentation#94