New release

.github/workflows/chech-duplicates-translations.yml → .github/workflows/check-duplicates-translations.yml

@@ -32,9 +32,12 @@ jobs:
           NUMBER_PULL=$(echo "$PR_JSON" | jq -r '.[0].number')
           labels=$(gh pr view $NUMBER_PULL --repo ovh/manager --json labels --jq '.labels[].name')
 
-          if echo "$labels" | grep -wq "translation required "; then
+          if echo "$labels" | grep -wq "translation required"; then
             echo "✅ Translation required: Check the duplicate translation pls!..."
-
+            SHOULD_CONTINUE=true
+            echo "should_continue<<EOF" >> $GITHUB_OUTPUT
+            echo "$SHOULD_CONTINUE" >> $GITHUB_OUTPUT
+            echo "EOF" >> $GITHUB_OUTPUT  
           else
             echo "❌ Translation label does not exist, exit..."
             SHOULD_CONTINUE=false
@@ -56,8 +59,12 @@ jobs:
         if: steps.gate.outputs.should_continue == 'true'
         uses: actions/cache@v3
         with:
-          path: '**/node_modules'
-          key: ${{ runner.os }}-${{ hashFiles('yarn.lock') }}
+          path: |
+            ~/.cache/yarn
+            node_modules
+          key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}
+          restore-keys: |
+            ${{ runner.os }}-yarn-
 
       - name: Install dependencies
         if: steps.gate.outputs.should_continue == 'true'
@@ -73,7 +80,7 @@ jobs:
           get_changed_packages() {
             BASE_BRANCH=${{ steps.gate.outputs.base_branch }}
             CURRENT_BRANCH=${{ steps.gate.outputs.current_branch }}
-            yarn turbo run build --dry-run=json --filter=...[origin/${BASE_BRANCH}...origin/${CURRENT_BRANCH}] > output.json
+            yarn pm:build:ci --dry-run=json --filter=...[origin/${BASE_BRANCH}...origin/${CURRENT_BRANCH}] > output.json
 
             # Clean JSON
             tail -n +3 output.json > tmpfile.json && mv tmpfile.json output.json

.github/workflows/linter.yaml

@@ -5,27 +5,42 @@ on:
     branches-ignore: [master, develop]
   pull_request:
     branches: [master, develop]
+
 jobs:
   build:
     name: Lint Code Base
     runs-on: ubuntu-latest
+
     steps:
+      # Checkout the code and include all commit history
       - name: Checkout Code
         uses: actions/checkout@v3
         with:
           fetch-depth: 0
+
+      # Setup Node.js 22.x environment
       - name: Use Node.js 22.x
         uses: actions/setup-node@v3
         with:
           node-version: 22
-      - name: Restore/create node_modules cache
+
+      # Restore and cache node_modules and yarn.lock related cache
+      - name: Restore node_modules cache
         uses: actions/cache@v3
         with:
-          path: '**/node_modules'
-          key: ${{ runner.os }}-${{ hashFiles('yarn.lock') }}
-      - name: Install repository
+          path: |
+            ~/.cache/yarn
+            node_modules
+          key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}
+          restore-keys: |
+            ${{ runner.os }}-yarn-
+
+      # Install dependencies only if necessary (cache hit will skip)
+      - name: Install dependencies
         run: |
           yarn install --frozen-lockfile
+
+      # Lint the code base
       - name: Lint Code Base
         run: |
           yarn lint

.github/workflows/run-bdd-tests.yml

@@ -13,11 +13,17 @@ jobs:
         uses: actions/setup-node@v3
         with:
           node-version: 22
-      - name: Restore/create node_modules cache
+      # Restore and cache node_modules and yarn.lock related cache
+      - name: Restore node_modules cache
         uses: actions/cache@v3
         with:
-          path: '**/node_modules'
-          key: ${{ runner.os }}-${{ hashFiles('yarn.lock') }}
+          path: |
+            ~/.cache/yarn
+            node_modules
+          key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}
+          restore-keys: |
+            ${{ runner.os }}-yarn-
+
       - name: Install repository
         run: yarn install --frozen-lockfile
       - name: Build covered packages and dependencies

packages/manager-tools/manager-pm/README.md

@@ -586,15 +586,16 @@ Because the monorepo runs **Yarn at the root** and **PNPM per-app**, you must fo
    }
    ```
 
-2. **Run `yarn install` from the root**  
-   This updates the root lockfile and triggers `manager-pm` hooks to:
-  - normalize versions
-  - rebuild PNPM overrides
-  - re-install PNPM apps if necessary
+2. **Run `yarn install` from the root:** this updates the root lockfile and triggers `manager-pm` hooks to:
+
+- normalize versions
+- rebuild PNPM overrides
+- re-install PNPM apps if necessary
 
 3. **Verify**
-  - For Yarn apps: `yarn workspace <app> why <dep>`
-  - For PNPM apps: `manager-pm --type pnpm --action build --app <app>`
+
+- For Yarn apps: `yarn workspace <app> why <dep>`
+- For PNPM apps: `manager-pm --type pnpm --action build --app <app>`
 
 ---
 

packages/manager-ui-kit/src/commons/tests-utils/Type.utils.tsx

@@ -1,4 +1,5 @@
 export interface Person extends Record<string, unknown> {
+  id: string;
   name: string;
   age: number;
   subRows?: Person[];

packages/manager-ui-kit/src/components/datagrid/Datagrid.component.tsx

@@ -2,7 +2,7 @@ import { useRef } from 'react';
 
 import { Table } from '@ovhcloud/ods-react';
 
-import { DatagridProps } from '@/components/datagrid/Datagrid.props';
+import { DatagridProps, ExpandableRow } from '@/components/datagrid/Datagrid.props';
 import { TableHeaderContent } from '@/components/datagrid/table/table-head';
 
 import { TableBody } from './table/table-body/TableBody.component';
@@ -14,7 +14,7 @@ import { useDatagrid } from './useDatagrid';
 const DEFAULT_ROW_HEIGHT = 50;
 const DEFAULT_CONTAINER_HEIGHT = 570;
 
-export const Datagrid = <T extends Record<string, unknown>>({
+export const Datagrid = <T extends ExpandableRow<T>>({
   autoScroll = true,
   columns,
   columnVisibility,
@@ -91,7 +91,7 @@ export const Datagrid = <T extends Record<string, unknown>>({
         />
       )}
       <div className="overflow-auto relative w-full" ref={tableContainerRef} style={containerStyle}>
-        <Table className="w-full">
+        <Table className="table table-fixed w-full">
           <TableHeaderContent<T>
             headerGroups={headerGroups}
             onSortChange={sorting?.setSorting}

packages/manager-ui-kit/src/components/datagrid/Datagrid.props.ts

@@ -48,7 +48,12 @@ export interface ExpandedProps {
   setExpanded: Dispatch<SetStateAction<ExpandedState>>;
 }
 
-export type DatagridProps<T extends Record<string, unknown>> = {
+export interface ExpandableRow<T> {
+  id?: string;
+  subRows?: T[];
+}
+
+export type DatagridProps<T extends ExpandableRow<T>> = {
   autoScroll?: boolean;
   columns: readonly DatagridColumn<T>[];
   columnVisibility?: ColumnVisibilityProps;

packages/manager-ui-kit/src/components/datagrid/__mocks__/index.tsx

@@ -62,8 +62,8 @@ export const mockIamResponse: IamAuthorizationResponse = {
 };
 
 export const mockData: Person[] = [
-  { name: 'John Doe', age: 30 },
-  { name: 'Jane Smith', age: 25 },
+  { id: '1', name: 'John Doe', age: 30 },
+  { id: '2', name: 'Jane Smith', age: 25 },
 ];
 
 export const mockBasicColumns: readonly DatagridColumn<Person>[] = [
@@ -160,6 +160,7 @@ export const mockFilters = {
 };
 
 export const mockExtendedData: Person[] = Array.from({ length: 5 }, (_, i) => ({
+  id: `person-${i + 1}`,
   name: `Person ${i + 1}`,
   age: i + 25,
 }));

packages/manager-ui-kit/src/components/datagrid/__tests__/Datagrid.spec.tsx

@@ -256,12 +256,12 @@ describe('Datagrid', () => {
         data: mockData,
         rowSelection: mockRowSelection,
       });
-      const head = container.querySelector('thead tr th label');
-      const body = container.querySelector('tbody tr td label');
-      expect(head).toBeInTheDocument();
-      expect(body).toBeInTheDocument();
-      expect(head).toHaveAttribute('id', 'checkbox:select-all');
-      expect(body).toHaveAttribute('id', 'checkbox:0');
+      const targetDiv = container.querySelector('thead tr th label');
+      expect(targetDiv).toBeInTheDocument();
+      expect(targetDiv).toHaveAttribute('id', 'checkbox:select-all');
+      const targetDivBody = container.querySelector('tbody tr td label');
+      expect(targetDivBody).toBeInTheDocument();
+      expect(targetDivBody).toHaveAttribute('id', 'checkbox:1');
     });
 
     it('should handle expandable rows', () => {