feat(okms): add current version information #19380
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjamet-ovh
force-pushed
the
feat/MANAGER-19657
branch
2 times, most recently
from
91d60d6 to
b877226
Compare
rjamet-ovh
requested review from
mathieumousnier
and removed request for
a team
...s/okms/src/modules/secret-manager/pages/drawers/secretValueDrawer/SecretValueDrawer.page.tsx
Outdated
Show resolved
Hide resolved
...pps/okms/src/modules/secret-manager/pages/secret/versionList/VersionCells.component.spec.tsx
Outdated
Show resolved
Hide resolved
...pps/okms/src/modules/secret-manager/pages/secret/versionList/VersionCells.component.spec.tsx
Show resolved
Hide resolved
...ager/apps/okms/src/modules/secret-manager/pages/secret/versionList/VersionList.page.spec.tsx
Outdated
Show resolved
Hide resolved
...s/src/modules/secret-manager/pages/drawers/secretValueDrawer/SecretValueDrawer.page.spec.tsx
Show resolved
Hide resolved
...ms/src/modules/secret-manager/pages/secret/generalInformation/InformationsTile.component.tsx
Show resolved
Hide resolved
rjamet-ovh
force-pushed
the
feat/MANAGER-19657
branch
from
b877226 to
43ed35c
Compare
github-actions
bot
added
the
has conflicts
...ager/apps/okms/src/modules/secret-manager/pages/secret/versionList/VersionCells.constants.ts
Outdated
Show resolved
Hide resolved
mathieumousnier
approved these changes
Sep 29, 2025
rjamet-ovh
force-pushed
the
feat/MANAGER-19657
branch
2 times, most recently
from
fdd22d7 to
67726c2
Compare
github-actions
bot
removed
the
has conflicts
tibs245
reviewed
Sep 30, 2025
Comment on lines
73
to
74
| <div className="grid grid-cols-1 gap-3 pt-2"> | ||
| <div className="flex gap-2 items-center h-8"> |
Contributor
There was a problem hiding this comment.
Why you need a div in div for only one div ? Can you replace it by a simple section to improve semantique ?
Contributor
Author
There was a problem hiding this comment.
I need two div to have the proper displayed layout. We're not in the context of a section here, the content of this component is a selector to update the content displayed below, so we really only have one content in the drawer in which this component is implemented.
tibs245
reviewed
Sep 30, 2025
| isDisplayTooltip | ||
| data-testid={VERSION_LIST_CELL_TEST_IDS.version(version)} | ||
| /> | ||
| <div className="flex gap-2 items-center"> |
Contributor
Author
There was a problem hiding this comment.
not really, this component is a datagrid cell, and i had to add a div to manage a use case where we have a link + a badge in the cell.
tibs245
approved these changes
Sep 30, 2025
ref: #MANAGER-19657 Signed-off-by: Romain Jamet <[email protected]>
rjamet-ovh
force-pushed
the
feat/MANAGER-19657
branch
from
67726c2 to
f8e87bd
Compare
This was referenced Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #MANAGER-19657
Description
Ticket Reference: #...
Additional Information