test(kms): add tests for credentials dashboard page #16583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathieumousnier
force-pushed
the
test/MANAGER-17841
branch
from
cf22d2c to
dbbc198
Compare
darsene
previously approved these changes
Apr 16, 2025
tibs245
reviewed
Apr 16, 2025
...-service/src/pages/credential/generalInformations/delete/DeleteCredentialModal.page.spec.tsx
Outdated
Show resolved
Hide resolved
tibs245
reviewed
Apr 16, 2025
...anagement-service/src/pages/credential/generalInformations/generalInformations.page.spec.tsx
Outdated
Show resolved
Hide resolved
tibs245
reviewed
Apr 16, 2025
...-service/src/pages/credential/generalInformations/delete/DeleteCredentialModal.page.spec.tsx
Outdated
Show resolved
Hide resolved
tibs245
reviewed
Apr 16, 2025
packages/manager/apps/key-management-service/src/pages/credential/Credential.page.spec.tsx
Outdated
Show resolved
Hide resolved
tibs245
reviewed
Apr 16, 2025
packages/manager/apps/key-management-service/src/pages/credential/Credential.page.spec.tsx
Outdated
Show resolved
Hide resolved
tibs245
reviewed
Apr 16, 2025
packages/manager/apps/key-management-service/src/pages/credential/Credential.page.spec.tsx
Outdated
Show resolved
Hide resolved
mathieumousnier
force-pushed
the
test/MANAGER-17841
branch
from
dbbc198 to
b0fb2d7
Compare
tibs245
previously approved these changes
Apr 17, 2025
darsene
reviewed
Apr 18, 2025
|
|
||
| const mockPageUrl = `/${okmsMock[0].id}/credentials/${credentialMock[0].id}`; | ||
|
|
||
| vi.mock('@ovh-ux/manager-react-shell-client', async (importOriginal) => { |
There was a problem hiding this comment.
Why use mock whereas it's an integration test ?
There was a problem hiding this comment.
I struggled with this at some point so i'm a bit surprised to see that it is indeed useless, don't remember why I've put this everywhere.
Anyways thank you, I removed it
ref: #MANAGER-17841 Signed-off-by: Mathieu Mousnier <[email protected]>
ref: #MANAGER-17841 Signed-off-by: Mathieu Mousnier <[email protected]>
mathieumousnier
force-pushed
the
test/MANAGER-17841
branch
from
b0fb2d7 to
d719b83
Compare
rjamet-ovh
approved these changes
Apr 22, 2025
tibs245
approved these changes
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add tests for credentials dashboard page
Ticket Reference: #MANAGER-17841