Skip to content

Conversation

@mathieumousnier
Copy link
Contributor

@mathieumousnier mathieumousnier commented Apr 4, 2025

Description

Add buttons on kms dashboard for downloading public CA certificates

Ticket Reference: #MANAGER-17309

Notes

I made small refactorings before implementing the feature :

  • Some fetch functions and hooks were a bit mixed, so I moved some code to group functions by subjects
  • Most files and functions use "Kms" and not "KMS" in there names, so i renamed a few ones I had to use

darsene
darsene previously approved these changes Apr 8, 2025
rjamet-ovh
rjamet-ovh previously approved these changes Apr 8, 2025
@mathieumousnier mathieumousnier dismissed stale reviews from rjamet-ovh and darsene via 43e669a April 8, 2025 13:54
rjamet-ovh
rjamet-ovh previously approved these changes Apr 9, 2025
darsene
darsene previously approved these changes Apr 9, 2025
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Apr 15, 2025
ref: #MANAGER-17309

Signed-off-by: Mathieu Mousnier <[email protected]>
ref: #MANAGER-17309

Signed-off-by: Mathieu Mousnier <[email protected]>
ref: #MANAGER-17309

Signed-off-by: Mathieu Mousnier <[email protected]>
ref: #MANAGER-17309

Signed-off-by: Mathieu Mousnier <[email protected]>
@mathieumousnier mathieumousnier dismissed stale reviews from darsene and rjamet-ovh via bf085db April 17, 2025 07:39
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Apr 17, 2025
pauldkn
pauldkn previously approved these changes Apr 17, 2025
darsene
darsene previously approved these changes Apr 17, 2025
@antleblanc antleblanc dismissed stale reviews from darsene and pauldkn via bd7ca4c April 28, 2025 09:39
@antleblanc antleblanc requested a review from a team April 28, 2025 09:39
@mathieumousnier mathieumousnier changed the base branch from develop to release/okms-w19 April 29, 2025 12:47
@mathieumousnier mathieumousnier merged commit b223150 into release/okms-w19 Apr 29, 2025
18 of 19 checks passed
@mathieumousnier mathieumousnier deleted the feat/MANAGER-17309 branch April 29, 2025 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants