Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(container): fix eloquant #12802

Merged
merged 1 commit into from
Aug 21, 2024
Merged

fix(container): fix eloquant #12802

merged 1 commit into from
Aug 21, 2024

Conversation

MaximeBajeux
Copy link
Contributor

Question Answer
Branch? master
Bug fix? yes
New feature? no
Breaking change? no
Tickets MANAGER-15084
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Related

fix(container): fix eloquant
d26ce7a 
ref: MANAGER-15084

Signed-off-by: Maxime Bajeux <[email protected]>
@MaximeBajeux MaximeBajeux requested review from a team as code owners August 20, 2024 16:39
@github-actions github-actions bot added container bug Something isn't working labels Aug 20, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 20, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
66.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@MaximeBajeux MaximeBajeux changed the base branch from master to release/incidents-gcj-w34 August 21, 2024 07:01
@MaximeBajeux MaximeBajeux merged commit 96e0214 into release/incidents-gcj-w34 Aug 21, 2024
14 of 15 checks passed
@MaximeBajeux MaximeBajeux deleted the fix/MANAGER-15084 branch August 21, 2024 07:01
@MaximeBajeux MaximeBajeux mentioned this pull request Aug 21, 2024
Merged
1 task
MaximeBajeux added a commit that referenced this pull request Aug 21, 2024
@MaximeBajeux
fix(container): fix eloquant (#12802)
0fbf08b 
ref: MANAGER-15084
Signed-off-by: Maxime Bajeux <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anooparveti anooparveti anooparveti approved these changes

@JacquesLarique JacquesLarique JacquesLarique approved these changes

@kqesar kqesar Awaiting requested review from kqesar kqesar was automatically assigned from ovh/su-digital-tools-core-stack

@frenautvh frenautvh Awaiting requested review from frenautvh frenautvh was automatically assigned from ovh/su-digital-tools-core-stack

@qpavy qpavy Awaiting requested review from qpavy qpavy was automatically assigned from ovh/team-manager-dev-angularjs

@oalkabouss oalkabouss Awaiting requested review from oalkabouss oalkabouss was automatically assigned from ovh/team-manager-dev-angularjs

@ghyenne ghyenne Awaiting requested review from ghyenne ghyenne was automatically assigned from ovh/team-manager-dev-angularjs

Assignees
No one assigned
Labels
bug Something isn't working container
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MaximeBajeux @anooparveti @JacquesLarique