Feat/breadcrumb #63
Merged
Feat/breadcrumb #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ady642
reviewed
Jun 5, 2023
...s/libraries/core/src/components/breadcrumb/breadcrumb-item/ods-breadcrumb-item-attributes.ts
Outdated
Show resolved
Hide resolved
Leotheluck
reviewed
Jun 5, 2023
| ) | ||
| } | ||
|
|
||
| /// @access private |
There was a problem hiding this comment.
wasn't there something we could do so that the IDE's interpretation of /// wouldn't be broken like this?
Leotheluck
reviewed
Jun 5, 2023
| // Main CSS mixin for typography | ||
| @mixin osds-breadcrumb-item-theme-typography() { | ||
| :host([size='md']) .breadcrumb-item__wrapper { | ||
| //$typography-properties: ods-get-typography-properties(body, '400'); |
There was a problem hiding this comment.
do we need to keep this?
There was a problem hiding this comment.
Not really no, it's not a big deal as it doesn't generate anything and could allow to quickly update if necessary.
But I kinda hope it won't be necessary anymore after some global CSS refacto :)
Leotheluck
approved these changes
Jun 5, 2023
ady642
approved these changes
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.