Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(global): rm forbidden word artifactory #30

Merged
merged 1 commit into from
Apr 28, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -136,5 +136,5 @@ Thumbs.db
# remove generated definition files
*.d.ts

# used file storing the artifactory token, used when building docker image
# used file storing the artijfrog token, used when building docker image
/artitoken
4 changes: 1 addition & 3 deletions packages/starters/react-vite/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,11 @@ cd my-react-vite-ods-app
```
> This clones the repo, copy the wanted starter and then clean up.

**2. Enable access to artifactory**
**2. Enable access (coming soon)**

This starter application is using `ODS` as dependency.
So you have to check if you have access to the registry with your credentials.

[See Documentation](../?path=/story/code-stencil-components-how-to-install--page#artifactory-access)

**3. Install dependencies**

```shell
Expand Down
4 changes: 1 addition & 3 deletions packages/starters/react/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,11 @@ cd my-react-ods-app
```
> This clones the repo, copy the wanted starter and then clean up.

**2. Enable access to artifactory**
**2. Enable access (coming soon)**

This starter application is using `ODS` as dependency.
So you have to check if you have access to the registry with your credentials.

[See Documentation](../?path=/story/code-stencil-components-how-to-install--page#artifactory-access)

**3. Install dependencies**

```shell
Expand Down
4 changes: 1 addition & 3 deletions packages/starters/vue-vite/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,13 +29,11 @@ cd my-vue-vite-ods-app

> This clones the repo, copy the wanted starter and then clean up.

**2. Enable access to artifactory**
**2. Enable access (coming soon)**

This starter application is using `ODS` as dependency.
So you have to check if you have access to the registry with your credentials.

[See Documentation](../?path=/story/code-stencil-components-how-to-install--page#artifactory-access)

**3. Install dependencies**

```shell
Expand Down
2 changes: 1 addition & 1 deletion scripts/generate-ods-doc.mjs
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#!/usr/bin/env zx
/**
* generate doc based on available packages from artifactory
* generate doc based on available packages from artijfrog
* execution from monorepo.
* `npx zx scripts/generate-ods-doc.mjs https://path-to-registry username token`
* OR
Expand Down