Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(code): display error when inserting long code inputs #138

Merged
merged 3 commits into from
Aug 11, 2023
+14 −21
Merged

fix(code): display error when inserting long code inputs #138

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0c3066d
fix(code): display error when inserting long code inputs
Aug 8, 2023
c5e7140
fix(code): display error when inserting long code inputs - review
Aug 8, 2023
5309b71
fix(code): display error when inserting long code inputs - review 2
Aug 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix(code): display error when inserting long code inputs - review 2
Francois Eoche committed Aug 11, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
commit 5309b71aa9b79778b9a56663cd2f66c7a88f8d5c
2 changes: 1 addition & 1 deletion packages/tools/storybook/stories/components/code/code.web-components.stories.ts
View file
Original file line number Diff line number Diff line change
@@ -53,7 +53,7 @@ Default.args = {
};

const TemplateCopy = (args: any) => html`
<osds-code ...=${getTagAttributes(args)}><osds-button slot="copy" title="copy text"></osds-button>${unsafeHTML(args.codeContent)}</osds-code>
<osds-code ...=${getTagAttributes(args)}><span slot="copy"><osds-button color="default" contrasted size="sm" variant="ghost"><osds-icon name="copy" size="xs" contrasted></osds-icon></osds-button></span>${unsafeHTML(args.codeContent)}</osds-code>
`;
export const Copy = TemplateCopy.bind({});
Copy.args = {