feat(pagination): address changes

ovh · Feb 2, 2024 · bab3bdd · bab3bdd
1 parent 512c11d
commit bab3bdd
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 6 deletions.
diff --git a/...components/src/pagination/src/components/osds-pagination/constants/pagination-per-page.ts b/...components/src/pagination/src/components/osds-pagination/constants/pagination-per-page.ts
@@ -1,14 +1,17 @@
 const ODS_PAGINATION_PER_PAGE_MIN = 10;
 const ODS_PAGINATION_PER_PAGE_MAX = 300;
 const ODS_PAGINATION_PER_PAGE_OPTIONS = Object.freeze([ODS_PAGINATION_PER_PAGE_MIN, 25, 50, 100, ODS_PAGINATION_PER_PAGE_MAX]);
-type ODS_PAGINATION_PER_PAGE = typeof ODS_PAGINATION_PER_PAGE_OPTIONS[number];
+
+export enum ODS_PAGINATION_PER_PAGE {
+  MIN = ODS_PAGINATION_PER_PAGE_MIN,
+  OPTION_25 = 25,
+  OPTION_50 = 50,
+  OPTION_100 = 100,
+  MAX = ODS_PAGINATION_PER_PAGE_MAX
+}
 
 export {
   ODS_PAGINATION_PER_PAGE_MAX,
   ODS_PAGINATION_PER_PAGE_MIN,
   ODS_PAGINATION_PER_PAGE_OPTIONS,
 };
-
-export type {
-  ODS_PAGINATION_PER_PAGE,
-};
diff --git a/packages/components/src/pagination/src/components/osds-pagination/osds-pagination.tsx b/packages/components/src/pagination/src/components/osds-pagination/osds-pagination.tsx
@@ -33,7 +33,7 @@ export class OsdsPagination implements OdsPaginationAttribute, OdsPaginationEven
   @Prop({ reflect: true }) labelTooltipPrevious: string = DEFAULT_ATTRIBUTE.labelTooltipPrevious;
   @Prop({ reflect: true }) labelTooltipNext: string = DEFAULT_ATTRIBUTE.labelTooltipNext;
 
-  @State() itemPerPage = this.defaultItemsPerPage ? this.defaultItemsPerPage : ODS_PAGINATION_PER_PAGE_MIN;
+  @State() itemPerPage = this.defaultItemsPerPage || ODS_PAGINATION_PER_PAGE_MIN;
   @State() pageList: OdsPaginationPageList = [];
 
   @Event() odsPaginationChanged!: EventEmitter<OdsPaginationChangedEventDetail>;