fix: review

Signed-off-by: Alexandre Esteves <[email protected]>
ovh · Nov 28, 2024 · 9c9e833 · 9c9e833
1 parent 73158a5
commit 9c9e833
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 39 deletions.
diff --git a/packages/ods/react/tests/_app/src/components/ods-textarea.tsx b/packages/ods/react/tests/_app/src/components/ods-textarea.tsx
@@ -1,21 +1,10 @@
-import { useFormik } from 'formik';
 import { OdsTextarea } from 'ods-components-react';
-import { ChangeEvent, type ReactElement } from 'react';
+import { type ReactElement } from 'react';
 import React from 'react-dom/client';
 
 // eslint-disable-next-line func-style
 const Textarea = (): ReactElement => {
-  const formik = useFormik({
-    initialValues: {
-      textarea: '',
-    },
-    onSubmit: (values) => {
-      console.log('Formik values', values);
-    },
-    validateOnMount: true,
-  });
-
-  function onOdsChange(e: ChangeEvent): void {
+  function onOdsChange(): void {
     console.log('React textarea odsChange');
   }
 
@@ -27,13 +16,6 @@ const Textarea = (): ReactElement => {
       <OdsTextarea isDisabled
         name="ods-textarea-disabled"
         onOdsChange={ onOdsChange } />
-
-      <OdsTextarea name="ods-textarea-formik"
-        onOdsChange={ (e) => {
-          onOdsChange(e);
-          return formik.handleChange(e);
-        } }
-        value={ formik.values.textarea } />
     </>
   );
 };

diff --git a/packages/ods/react/tests/e2e/ods-textarea.e2e.ts b/packages/ods/react/tests/e2e/ods-textarea.e2e.ts
@@ -48,19 +48,4 @@ describe('ods-textarea react', () => {
 
     expect(consoleLog).toBe('');
   });
-
-  it('should not do an infinite loop', async () => {
-    const elem = await page.$('ods-textarea[name="ods-textarea-formik"] >>> textarea');
-    let consoleLog = '';
-    page.on('console', (consoleObj) => {
-      console.log('consoleObj', consoleObj.text())
-      consoleLog += consoleObj.text();
-    });
-
-    await elem?.type('a');
-    // Small delay to ensure page console event has been resolved
-    await new Promise((resolve) => setTimeout(resolve, 100));
-
-    expect(consoleLog).toBe('React textarea odsChangeReact textarea odsChange');
-  });
 });
diff --git a/packages/ods/src/components/datepicker/tests/behaviour/ods-datepicker.e2e.ts b/packages/ods/src/components/datepicker/tests/behaviour/ods-datepicker.e2e.ts
@@ -235,7 +235,6 @@ describe('ods-datepicker behaviour', () => {
         }, dummyValue);
         await page.waitForChanges();
 
-        // expect(await el.getProperty('value')).toBe(new Date(dummyValue).toISOString());
         expect(odsValueChangeSpy).toHaveReceivedEventTimes(1);
       });
     });

diff --git a/packages/ods/src/components/input/tests/behaviour/ods-input.e2e.ts b/packages/ods/src/components/input/tests/behaviour/ods-input.e2e.ts
@@ -256,7 +256,7 @@ describe('ods-input behaviour', () => {
         expect(odsValueChangeSpy).toHaveReceivedEventTimes(1);
       });
 
-      it('should not do an infinite loop with string', async() => {
+      it('should not do an infinite loop with number', async() => {
         const dummyValue = 2;
         await setup('<ods-input></ods-input>');
         const odsValueChangeSpy = await page.spyOnEvent('odsChange');

diff --git a/packages/ods/src/components/phone-number/tests/behaviour/ods-phone-number.e2e.ts b/packages/ods/src/components/phone-number/tests/behaviour/ods-phone-number.e2e.ts
@@ -276,7 +276,7 @@ describe('ods-phone-number behaviour', () => {
       });
 
       it('should not do an infinite loop', async() => {
-        const dummyValue = '0123456789';
+        const dummyValue = '+33123456789';
         await setup('<ods-phone-number iso-code="fr"></ods-phone-number>');
         const odsValueChangeSpy = await page.spyOnEvent('odsChange');
 
@@ -290,7 +290,7 @@ describe('ods-phone-number behaviour', () => {
         await el.setAttribute('value', dummyValue);
         await page.waitForChanges();
 
-        expect(await el.getProperty('value')).toBe('+33' + dummyValue.substring(1));
+        expect(await el.getProperty('value')).toBe(dummyValue);
         expect(odsValueChangeSpy).toHaveReceivedEventTimes(1);
       });
     });