fix(select): observable for label change (#284)

ovh · Nov 21, 2023 · 272075b · 272075b
1 parent c780d57
commit 272075b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/packages/components/select/src/components/osds-select/osds-select.tsx b/packages/components/select/src/components/osds-select/osds-select.tsx
@@ -287,7 +287,7 @@ export class OsdsSelect implements OdsSelectAttribute, OdsSelectEvent, OdsSelect
 
   setSelectOptions() {
     this.controller.selectOptions = this.getSelectOptionList();
-    this.controller.selectOptions.forEach((option) => this.observer?.observe(option, { childList: true }));
+    this.controller.selectOptions.forEach((option) => this.observer?.observe(option, { childList: true, attributes: true, subtree: true }));
   }
 
   getSelectOptionList(): (HTMLElement & OsdsSelectOption)[] {

diff --git a/packages/components/select/src/dev.ts b/packages/components/select/src/dev.ts
@@ -88,6 +88,10 @@ export default function() {
 
   (window as any).select1Toggle = function(/*evt: Event*/) {
     logger.log('select1Toggle');
+    const options = document.querySelectorAll('#select1 > osds-select-option');
+    options.forEach((option) => {
+      option.innerHTML = `NewValue${option.getAttribute('value')}`;
+    });
     // todo
     // examples.select1.component && (examples.select1.component.opened = !examples.select1.component.opened);
     // evt.stopPropagation()