Skip to content

Commit

Permalink
fix(select): fix broken e2e screenshot tests
Browse files Browse the repository at this point in the history
  • Loading branch information
dpellier committed Sep 26, 2023
1 parent 3c140e1 commit 02e409e
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,8 @@ describe('e2e:osds-select-group', () => {
let page: E2EPage;
let el: E2EElement;

async function setup({ onPage }: { onPage?: ({ page }: { page: E2EPage }) => void } = {}) {
async function setup() {
page = await newE2EPage();
onPage && onPage({ page });

await page.setContent(`
<osds-select-group>
Expand Down Expand Up @@ -37,7 +36,7 @@ describe('e2e:osds-select-group', () => {
// Todo : add active behaviour on top of hover and focus
screenshotActions.forEach(({ actionDescription, action }) => {
it(actionDescription, async () => {
await setup({});
await setup();
action();
await page.waitForChanges();

Expand Down
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
import type { E2EPage } from '@stencil/core/testing';
import { E2EElement, newE2EPage } from '@stencil/core/testing';
import { DEFAULT_ATTRIBUTE } from './constants/default-attributes';
import { ODS_SELECT_SIZE } from './constants/select-size';
import { OdsSelectAttribute } from './interfaces/attributes';
import { odsComponentAttributes2StringAttributes, odsStringAttributes2Str } from '@ovhcloud/ods-common-testing';
import { ODS_THEME_COLOR_INTENT } from '@ovhcloud/ods-common-theming';


describe('e2e:osds-select', () => {
let page: E2EPage;
let el: E2EElement;
Expand Down

0 comments on commit 02e409e

Please sign in to comment.