Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename method. #699

Merged
merged 2 commits into from
May 15, 2017
Merged

Rename method. #699

merged 2 commits into from
May 15, 2017

Conversation

mingyoung
Copy link
Collaborator

考虑到公众号为 app_id,企业号为 corp_id
修改两个方法:
getAppId() => getClientId()
getSecret() => getClientSecret()

@@ -35,14 +35,14 @@
*
* @var string
*/
protected $clientId;
private $clientId;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

还是 protected 吧

@overtrue overtrue merged commit 661e723 into w7corp:develop May 15, 2017
@mingyoung mingyoung deleted the rename-method branch May 15, 2017 12:18
@never615
Copy link

@mingyoung 你在正在添加企业号的相关接口吗?

@mingyoung
Copy link
Collaborator Author

@never615

@never615
Copy link

@mingyoung 带企业号功能的第一版预计什么时候会发布呢?如果久的话,我就要自己先做了.

@mingyoung
Copy link
Collaborator Author

mingyoung commented May 17, 2017 via email

@never615
Copy link

@mingyoung
develop分支里面大的代码结构调整完了吧?完了的话我就按里面的结构写企业号服务商的代码了.我见你建了enterpriseaccount的目录,企业服务商应该和它同级在建一个目录吧.
还有develop里面php版本怎么变成>7.1了...

@mingyoung
Copy link
Collaborator Author

@never615
或许 EnterpriseAccount 会改成 WeWork。
你可以先写,慢慢再调整吧。🤣

never615 added a commit to never615/wechat that referenced this pull request May 19, 2017
* 'develop' of github.com:overtrue/wechat: (56 commits)
  Rename method. (w7corp#699)
  Apply fixes from StyleCI (w7corp#698)
  Tweak open-platform code.
  add return types.
  修正素材管理中的返回值文档注释,正确的类型应该是集合,而不是字符串。 (w7corp#695)
  Add official-account core service provider.
  Apply fixes from StyleCI (w7corp#684)
  separate open-platform service providers.
  Apply fixes from StyleCI (w7corp#683)
  Sorted class.
  cleanup open-platform class.
  Remove old files.
  separate mini-program service providers.
  Apply fixes from StyleCI (w7corp#682)
  Move `AbstractAPI` class.
  Apply fixes from StyleCI (w7corp#681)
  Move `Http` class.
  Apply fixes from StyleCI (w7corp#680)
  Minimum PHP version.
  add test.
  ...

# Conflicts:
#	composer.json
#	src/Foundation/Application.php
#	src/OpenPlatform/ServiceProvider.php
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants