-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename method. #699
Merged
Merged
Rename method. #699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
overtrue
reviewed
May 15, 2017
src/Foundation/Core/AccessToken.php
Outdated
@@ -35,14 +35,14 @@ | |||
* | |||
* @var string | |||
*/ | |||
protected $clientId; | |||
private $clientId; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
还是 protected 吧
@mingyoung 你在正在添加企业号的相关接口吗? |
@mingyoung 带企业号功能的第一版预计什么时候会发布呢?如果久的话,我就要自己先做了. |
没那么快哦,估计一两个月吧 😂
|
@mingyoung |
@never615 |
never615
added a commit
to never615/wechat
that referenced
this pull request
May 19, 2017
* 'develop' of github.com:overtrue/wechat: (56 commits) Rename method. (w7corp#699) Apply fixes from StyleCI (w7corp#698) Tweak open-platform code. add return types. 修正素材管理中的返回值文档注释,正确的类型应该是集合,而不是字符串。 (w7corp#695) Add official-account core service provider. Apply fixes from StyleCI (w7corp#684) separate open-platform service providers. Apply fixes from StyleCI (w7corp#683) Sorted class. cleanup open-platform class. Remove old files. separate mini-program service providers. Apply fixes from StyleCI (w7corp#682) Move `AbstractAPI` class. Apply fixes from StyleCI (w7corp#681) Move `Http` class. Apply fixes from StyleCI (w7corp#680) Minimum PHP version. add test. ... # Conflicts: # composer.json # src/Foundation/Application.php # src/OpenPlatform/ServiceProvider.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
考虑到公众号为
app_id
,企业号为corp_id
修改两个方法:
getAppId()
=>getClientId()
getSecret()
=>getClientSecret()