Fix regex in read_configuration function For MacOS #393
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request corrects a command in a setup script that fails to parse configuration values correctly on macOS. Specifically, when attempting to extract the MongoDB version from
config/overleaf.rc
, the existingsed
command returns the entire lineMONGO_VERSION=7.0
instead of the required value7.0
.The issue originates from fundamental differences between the GNU
sed
implementation (common on Linux) and the BSDsed
implementation (used by macOS). The script's regular expression relies on behavior specific to GNUsed
, causing the substitution to fail silently on macOS.To resolve this and enhance script portability, this change replaces the non-portable
sed
command with the universally availablecut
command. The modified pipeline continues to usegrep
to isolate the target line, but then passes the result tocut
. Using the equals sign=
as a delimiter,cut
cleanly extracts the version value. This approach is simple, avoids the complexities of cross-platform regular expressions, and guarantees consistent behavior across both Linux and macOS environments.Related issues / Pull Requests
Fixes a developer setup issue on macOS where environment variables are not parsed correctly.
Contributor Agreement