Skip to content
This repository has been archived by the owner on Dec 17, 2021. It is now read-only.

Jpa eslint basepath fix #21

Merged
merged 2 commits into from
Jul 2, 2020
Merged

Conversation

das7pad
Copy link
Member

@das7pad das7pad commented Jul 2, 2020

No description provided.

@mans0954
Copy link
Contributor

mans0954 commented Jul 2, 2020

I did think of doing something like this, but if there's no urgency to upgrade eslint, might be better to wait for an upstream patch? prettier/prettier-eslint-cli#259

@das7pad
Copy link
Member Author

das7pad commented Jul 2, 2020

I did think of doing something like this, but if there's no urgency to upgrade eslint, might be better to wait for an upstream patch? prettier/prettier-eslint-cli#259

That patch is 1+ year old. See also https://github.com/overleaf/dev-environment/pull/312 which has landed in most of the repositories.

$ grep */package.json -e '"format": ' | grep -e PWD | wc -l 
19
$ grep */package.json -e '"format": ' | grep -v -e PWD | wc -l 
3

@das7pad das7pad merged commit f95bd48 into csh-update-deps-sha1 Jul 2, 2020
@das7pad das7pad deleted the jpa-eslint-basepath-fix branch July 2, 2020 11:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants