refactor: change annotations to use built-in generic types #781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@kdmccormick @regisb This is ready for review |
regisb
requested changes
Jan 12, 2023
Contributor
regisb
left a comment
regisb
left a comment
There was a problem hiding this comment.
Looking good, thanks! Just a few minor comments.
Carlos-Muniz
force-pushed
the
Carlos-Muniz/built-in-generic-types
branch
from
54e274b to
a61d275
Compare
Adds `from __future__ import annotations` to the top of every module, right below the module's docstring. Replaces any usages of t.List, t.Dict, t.Set, t.Tuple, and t.Type with their built-in equivalents: list, dict, set, tuple, and type. Ensures that make test still passes under Python 3.7, 3.8 and 3.9.
Carlos-Muniz
force-pushed
the
Carlos-Muniz/built-in-generic-types
branch
from
a61d275 to
aebb04a
Compare
regisb
approved these changes
Jan 18, 2023
Contributor
regisb
left a comment
regisb
left a comment
There was a problem hiding this comment.
Thanks for your contribution!
Contributor
|
I realized only now that your PR was on the nightly branch. I'll backport the commit to the master branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes annotations from
typingto use built-in generic types from__future__.annotationsCloses openedx-unsupported/wg-developer-experience#130