feat: upgrade Open edX Image to Python 3.11 - #1056
Merged
Merged
Conversation
This was referenced May 2, 2024
DawoudSheraz
marked this pull request as ready for review
May 2, 2024 15:07
kdmccormick
approved these changes
May 7, 2024
kdmccormick
left a comment
kdmccormick
left a comment
Collaborator
There was a problem hiding this comment.
I confirmed that the containers now run Python 3.11, and that I was able to run LMS, CMS, and some unit tests under 3.11. Thanks @DawoudSheraz !
| @@ -0,0 +1 @@ | |||
| - [Feature] Upgrade Open edX Dockerfile to use Python 3.11 (by @dawoudsheraz) | |||
Collaborator
There was a problem hiding this comment.
I suggest mentioning openedx image rather than the openedx Dockerfile. The reason I say this is that the Dockerfile is an implementation detail that not every Tutor user thinks about, but all Tutor users are aware of the image.
DawoudSheraz
force-pushed
the
dsheraz/py311
branch
from
May 8, 2024 16:43
f9c003a to
203dcbb
Compare
DawoudSheraz
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates Tutor Open edX dockerfile to setup Python 3.11. Some dependencies have been updated as well. Upsteam PR openedx/openedx-platform#34374.
This PR is currently doing upgrade using pyenv. A followup PR that setups Python 3.11 from Python image would be merged later (#1057). It is currently being tested.
Testing Instructions
tutor config save. Verify docker file has been updatedtutor images build opened --no-cacheto build a clean image. Verify the image builds as expected. Verify the PYthon inside image is 3.11