Skip to content

feat: [FC-86] Added support for the new Catalog MFE - #259

Merged
arbrandes merged 3 commits into
overhangio:mainfrom
raccoongang:Peter_Kulko/add-support-for-the-new-Catalog-MFE
Feb 5, 2026
Merged

feat: [FC-86] Added support for the new Catalog MFE#259
arbrandes merged 3 commits into
overhangio:mainfrom
raccoongang:Peter_Kulko/add-support-for-the-new-Catalog-MFE

Conversation

@peterkulko

@peterkulko peterkulko commented May 26, 2025

Copy link
Copy Markdown
Contributor

Description

This PR includes the configuration for the new Catalog MFE (Verawood release).

PR with an installation example for the Catalog MFE as a Tutor plugin - openedx/frontend-app-catalog#60

How Has This Been Tested?

  1. Clone this repository
  2. Use the local version of this tutor plugin
  3. Rebuild the mfe image
  4. Go to http://apps.local.openedx.io:1998/catalog/

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Sandbox, if applicable.
  • Is there adequate test coverage for your changes?

Post-merge Checklist

  • Deploy the changes to prod after verifying on stage or ask @openedx/edx-infinity to do it.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@peterkulko peterkulko changed the title DRAFT: add support for the Catalog MFE DRAFT: Added support for the new Catalog MFE May 26, 2025
@DawoudSheraz DawoudSheraz moved this from Pending Triage to In Progress in Tutor project management May 30, 2025
@DawoudSheraz

Copy link
Copy Markdown
Contributor

Hi, isn't this a repeat of #257?

@peterkulko
peterkulko marked this pull request as ready for review June 26, 2025 06:31
@peterkulko peterkulko changed the title DRAFT: Added support for the new Catalog MFE feat: Added support for the new Catalog MFE Jun 26, 2025
@DawoudSheraz DawoudSheraz moved this from In Progress to Blocked in Tutor project management Jul 15, 2025
@peterkulko peterkulko changed the title feat: Added support for the new Catalog MFE feat: [FC-86] Added support for the new Catalog MFE Jul 29, 2025
@peterkulko
peterkulko marked this pull request as draft September 9, 2025 10:03
@peterkulko

Copy link
Copy Markdown
Contributor Author

@brian-smith-tcril I’d like to kindly suggest taking a look at this PR. We can merge it a bit later, once everything is ready. Would that work for you?
Unfortunately, I don’t have the permissions to add you as a reviewer directly.

@brian-smith-tcril brian-smith-tcril left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall the changes here make sense, but I think we might need some minor changes to the logic.

I noticed

{% if get_mfe("catalog") %}
FEATURES['ENABLE_CATALOG_MICROFRONTEND'] = True
{% endif %}

looks almost identical to

{% if get_mfe("authn") %}
FEATURES['ENABLE_AUTHN_MICROFRONTEND'] = True
{% endif %}

and

"catalog": {
"repository": "https://github.com/openedx/frontend-app-catalog.git",
"port": 1998,
},

is being added to CORE_MFE_APPS.

This makes me think that this PR is putting the catalog MFE in a "default on" state. For Ulmo, the goal is to allow site operators to switch from the legacy catalog to the Catalog MFE, but not default to it.

@arbrandes - do you know how we've handled this in the past?

@arbrandes

Copy link
Copy Markdown
Collaborator

@brian-smith-tcril, in the past the optionality of an MFE came down to either it being defined in an optional plugin (like Learner Record via tutor-credentials), or a feature/waffle flag.

Because of the nature of the Catalog MFE (particularly, the fact it's the first thing anybody sees, also people can use it logged out), I think the best thing is to go via a plugin.

@peterkulko

Copy link
Copy Markdown
Contributor Author

@brian-smith-tcril, in the past the optionality of an MFE came down to either it being defined in an optional plugin (like Learner Record via tutor-credentials), or a feature/waffle flag.

Because of the nature of the Catalog MFE (particularly, the fact it's the first thing anybody sees, also people can use it logged out), I think the best thing is to go via a plugin.

Thanks! I have a question and would appreciate your thoughts. Since the Catalog MFE isn’t part of another service (like tutor-credentials) and we have FEATURES['ENABLE_CATALOG_MICROFRONTEND'], would it make sense to simply set this flag to False and add a few notes in the tutor-mfe documentation?

This way, the Catalog MFE would be disabled by default but could still be enabled if needed. Please let me know if I’m misunderstanding anything.

@peterkulko
peterkulko force-pushed the Peter_Kulko/add-support-for-the-new-Catalog-MFE branch from df25f8d to 3aee1e2 Compare December 15, 2025 09:23
@peterkulko
peterkulko marked this pull request as ready for review December 15, 2025 09:29

@kyrylo-kh kyrylo-kh left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@arbrandes arbrandes left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@arbrandes

Copy link
Copy Markdown
Collaborator

@regisb, any objections? Anybody else at Edly I should be asking?

@arbrandes arbrandes linked an issue Jan 29, 2026 that may be closed by this pull request
@arbrandes

Copy link
Copy Markdown
Collaborator

Going ahead and merging this so people can give early feedback.

@arbrandes
arbrandes merged commit aaf77f3 into overhangio:main Feb 5, 2026
2 checks passed
@github-project-automation github-project-automation Bot moved this from Blocked to Done in Tutor project management Feb 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

Enable Catalog MFE by default in Tutor

8 participants