Skip to content

chore: remove unnecessary settings and waffle flags for account and profile MFEs #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DawoudSheraz merged 3 commits into from
Apr 22, 2025
Merged

chore: remove unnecessary settings and waffle flags for account and profile MFEs #246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
91031a9
chore: remove unnecessary site-configuration changes for profile MFE
Danyal-Faheem Mar 24, 2025
c785443
chore: remove unnecessary waffle flags for account and profile MFE
Danyal-Faheem Mar 24, 2025
9a9a156
docs: add changelog entry
Danyal-Faheem Mar 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/20250324_232034_danyal.faheem_remove_site_configuration_script.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- [Improvement] Remove unnecessary site-configuration settings and waffle flags for the account and profile MFEs. (by @Danyal-Faheem)
12 changes: 0 additions & 12 deletions tutormfe/templates/mfe/tasks/lms/init
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,21 +2,9 @@
./manage.py lms waffle_flag --list > /tmp/lms_waffle_flags.txt

{% if is_mfe_enabled("account") %}
grep account.redirect_to_microfrontend /tmp/lms_waffle_flags.txt || ./manage.py lms waffle_flag --create --everyone account.redirect_to_microfrontend
./manage.py lms populate_retirement_states
{% else %}
./manage.py lms waffle_delete --flags account.redirect_to_microfrontend
{% endif %}

{% if is_mfe_enabled("profile") %}
grep learner_profile.redirect_to_microfrontend /tmp/lms_waffle_flags.txt || ./manage.py lms waffle_flag --create --everyone learner_profile.redirect_to_microfrontend
site-configuration set --domain={{ LMS_HOST }} ENABLE_PROFILE_MICROFRONTEND true
site-configuration set --domain={{ LMS_HOST }}:8000 ENABLE_PROFILE_MICROFRONTEND true
{% else %}
site-configuration unset --domain={{ LMS_HOST }} ENABLE_PROFILE_MICROFRONTEND
site-configuration unset --domain={{ LMS_HOST }}:8000 ENABLE_PROFILE_MICROFRONTEND
./manage.py lms waffle_delete --flags learner_profile.redirect_to_microfrontend
{% endif %}

{% if is_mfe_enabled("learner-dashboard") %}
grep learner_home_mfe.enabled /tmp/lms_waffle_flags.txt || ./manage.py lms waffle_flag --create --everyone learner_home_mfe.enabled
Expand Down