Skip to content

Conversation

@mcg-web
Copy link
Contributor

@mcg-web mcg-web commented Sep 22, 2021

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? no
Documented? no
Fixed tickets none
License MIT

@mcg-web mcg-web changed the base branch from master to 0.12 September 22, 2021 14:50
@mcg-web mcg-web closed this Sep 22, 2021
@mcg-web mcg-web reopened this Sep 22, 2021
@mcg-web
Copy link
Contributor Author

mcg-web commented Sep 22, 2021

@Vincz seem like annotations parser tests failed, can you have a look on this please?

@Vincz
Copy link
Collaborator

Vincz commented Sep 22, 2021

Hey @mcg-web :-)

The problem comes from an update from Doctrine. It used to set the column type to string by default in the parsing. Now it's done later. To solve this, change this line:

$type = $this->resolveTypeFromDoctrineType($columnAnnotation->type);

by:

$type = $this->resolveTypeFromDoctrineType($columnAnnotation->type ?: 'string'); 

The problem has been solved in PR #867. Do you want me to open a PR on your repo ?

@mcg-web
Copy link
Contributor Author

mcg-web commented Sep 22, 2021

Can you submit a PR to 0.12 with this fix please ?

@mcg-web mcg-web merged commit 1acc917 into overblog:0.12 Sep 22, 2021
@mcg-web mcg-web deleted the fix-ci-builds branch September 22, 2021 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants