Repository navigation
init: the detached tld's holes_floor_kept is an atomic - #51
Merged
Merged
Conversation
A C++ compiler that implements _Atomic(size_t) as std::atomic<size_t> rejects a plain 0 for it in mi_tld_detached's initializer (the copy constructor is deleted): an embedder that compiles static.c with -x c++ stopped there. MI_ATOMIC_VAR_INIT(0), as the other atomics of the struct have.
Jarred-Sumner
added a commit
to oven-sh/bun
that referenced
this pull request
Sep 15, 2026
…is initialised as one) The Windows lanes compile mimalloc's static.c as C++14, where a plain 0 for an _Atomic(size_t) member of a static initializer needs std::atomic's deleted copy constructor. The fork's head has it as MI_ATOMIC_VAR_INIT(0).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mi_tld_detached's static initializer gave the new_Atomic(size_t) holes_floor_kept(#50) a plain0. A C++ compiler that implements_Atomic(T)asstd::atomic<T>rejects that (deleted copy constructor), so an embedder that compilesstatic.cwith-x c++(clang-cl, MSVC headers) fails atinit.c:136. It isMI_ATOMIC_VAR_INIT(0)now, like the struct's other atomics.Checked with
clang++ -x c++ -fsyntax-only -I include src/static.c: one error without the change, none with it.