Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(install): auto node-gyp script bugfix #9289

Merged
merged 2 commits into from
Mar 7, 2024

Conversation

dylan-conway
Copy link
Collaborator

@dylan-conway dylan-conway commented Mar 7, 2024

What does this PR do?

Auto node-gyp scripts can be added if preinstall and install don't exist. Previously we were checking for install and postinstall.

fixes first bug mentioned here microsoft/node-pty#632 (comment)

How did you verify your code works?

existing tests

Copy link
Contributor

github-actions bot commented Mar 7, 2024

@dylan-conway 1 files with test failures on linux-x64:

View test output

#4aa3c39ca020aed580201d317a7e72d0147d4791

Copy link
Contributor

github-actions bot commented Mar 7, 2024

@dylan-conway 1 files with test failures on linux-x64-baseline:

View test output

#4aa3c39ca020aed580201d317a7e72d0147d4791

Copy link
Contributor

github-actions bot commented Mar 7, 2024

Copy link
Contributor

github-actions bot commented Mar 7, 2024

Copy link
Contributor

github-actions bot commented Mar 7, 2024

❌🪟 @dylan-conway, there are 12 test regressions on Windows x86_64

  • test\cli\install\bun-upgrade.test.ts
  • test\cli\run\transpiler-cache.test.ts
  • test\js\bun\dns\resolve-dns.test.ts
  • test\js\bun\http\fetch-file-upload.test.ts
  • test\js\bun\http\bun-server.test.ts
  • test\js\bun\shell\shelloutput.test.ts
  • test\js\bun\shell\throw.test.ts
  • test\js\node\dns\node-dns.test.js
  • test\js\node\process\process-args.test.js
  • test\js\web\fetch\body-stream-excess.test.ts
  • test\js\web\fetch\body-stream.test.ts
  • test\js\web\timers\performance.test.js

Full Test Output

@Jarred-Sumner Jarred-Sumner merged commit ea6bf12 into main Mar 7, 2024
26 of 31 checks passed
@Jarred-Sumner Jarred-Sumner deleted the dylan/auto-node-gyp-bugfix branch March 7, 2024 07:05
@Jarred-Sumner
Copy link
Collaborator

nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants